From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaMGQ-0003Ka-AW for qemu-devel@nongnu.org; Thu, 09 May 2013 04:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaMGP-0003lY-81 for qemu-devel@nongnu.org; Thu, 09 May 2013 04:31:46 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:47768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaMGP-0003lO-2L for qemu-devel@nongnu.org; Thu, 09 May 2013 04:31:45 -0400 Received: by mail-we0-f174.google.com with SMTP id x53so2618438wes.33 for ; Thu, 09 May 2013 01:31:44 -0700 (PDT) Date: Thu, 9 May 2013 10:31:41 +0200 From: Stefan Hajnoczi Message-ID: <20130509083141.GI1074@stefanha-thinkpad.redhat.com> References: <1368060022-16911-1-git-send-email-qemulist@gmail.com> <1368060022-16911-2-git-send-email-qemulist@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368060022-16911-2-git-send-email-qemulist@gmail.com> Subject: Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Peter Maydell , Anthony Liguori , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini On Thu, May 09, 2013 at 08:40:22AM +0800, Liu Ping Fan wrote: > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9e88320..77e0d40 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -192,6 +192,16 @@ struct MemoryRegionSection { > > typedef struct MemoryListener MemoryListener; > > +/* The list of priority, ex, vhost should have higher priority (less num) than > + * kvm, ie PRI_VRING < PRI_HYPV s/PRI_HYPV/PRI_HYPERV/ > + */ > +typedef enum { > + PRI_DEFAULT = 0, > + PRI_CORE = 1, > + PRI_VRING = 9, > + PRI_HYPERV = 10, HYPERV == hypervisor? Easy to confuse with Microsoft Hyper-V. Please use PRI_ACCEL or PRI_HYPERVISOR.