From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUqz-0008B1-Fg for qemu-devel@nongnu.org; Thu, 09 May 2013 13:42:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaUqy-0001uq-7S for qemu-devel@nongnu.org; Thu, 09 May 2013 13:42:05 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaUqy-0001ua-16 for qemu-devel@nongnu.org; Thu, 09 May 2013 13:42:04 -0400 Date: Thu, 9 May 2013 19:42:00 +0200 From: Aurelien Jarno Message-ID: <20130509174200.GC19954@ohm.aurel32.net> References: <1368120517-84396-1-git-send-email-petar.jovanovic@rt-rk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1368120517-84396-1-git-send-email-petar.jovanovic@rt-rk.com> Subject: Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Petar Jovanovic Cc: qemu-devel@nongnu.org, petar.jovanovic@imgtec.com On Thu, May 09, 2013 at 07:28:37PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This is a small follow-up change to "fix incorrect behaviour for INSV". > > It includes two minor modifications: > > - sizefilter is constant so it can be moved inside of the block, > - (int64_t)0x01 is replaced with 1LL for ease of reading. > > No functional change. > > Signed-off-by: Petar Jovanovic > --- > target-mips/dsp_helper.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c > index 9212789..426a3b6 100644 > --- a/target-mips/dsp_helper.c > +++ b/target-mips/dsp_helper.c > @@ -2900,11 +2900,12 @@ target_ulong helper_bitrev(target_ulong rt) > return (target_ulong)rd; > } > > -#define BIT_INSV(name, posfilter, sizefilter, ret_type) \ > +#define BIT_INSV(name, posfilter, ret_type) \ > target_ulong helper_##name(CPUMIPSState *env, target_ulong rs, \ > target_ulong rt) \ > { \ > uint32_t pos, size, msb, lsb; \ > + uint32_t const sizefilter = 0x3F; \ > target_ulong filter; \ > target_ulong temp, temprs, temprt; \ > target_ulong dspc; \ > @@ -2921,7 +2922,7 @@ target_ulong helper_##name(CPUMIPSState *env, target_ulong rs, \ > return rt; \ > } \ > \ > - filter = ((int64_t)0x01 << size) - 1; \ > + filter = (1LL << size) - 1; \ > filter = filter << pos; \ > temprs = (rs << pos) & filter; \ > temprt = rt & ~filter; \ > @@ -2930,9 +2931,9 @@ target_ulong helper_##name(CPUMIPSState *env, target_ulong rs, \ > return (target_long)(ret_type)temp; \ > } > > -BIT_INSV(insv, 0x1F, 0x3F, int32_t); > +BIT_INSV(insv, 0x1F, int32_t); > #ifdef TARGET_MIPS64 > -BIT_INSV(dinsv, 0x7F, 0x3F, target_long); > +BIT_INSV(dinsv, 0x7F, target_long); > #endif > > #undef BIT_INSV Thanks, queued for 1.6. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net