From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UapJS-0003J9-Rz for qemu-devel@nongnu.org; Fri, 10 May 2013 11:32:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UapJR-00024o-Ny for qemu-devel@nongnu.org; Fri, 10 May 2013 11:32:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UapJR-00024h-G8 for qemu-devel@nongnu.org; Fri, 10 May 2013 11:32:49 -0400 Date: Fri, 10 May 2013 11:30:20 -0400 From: Luiz Capitulino Message-ID: <20130510113020.3467823e@redhat.com> In-Reply-To: <1368152462-13219-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368152462-13219-1-git-send-email-mdroth@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: akong@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org On Thu, 9 May 2013 21:20:52 -0500 Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qapi-native-lists > > Sending this now since a number of series have popped up in the past that > wanted this, and Amos has some pending patches (query-mac-tables) that rely > on this as well. > > These patches add support for specifying lists of native qapi types > (int/bool/str/number) like so: > > { 'type': 'foo', > 'data': { 'bar': ['int'] }} > > for a 'bar' field that is a list of type 'int', > > { 'type': 'foo2', > 'data': { 'bar2': ['str'] }} > > for a 'bar2' field that is a list of type 'str', and so on. > > This uses linked list types for the native C representations, just as we do > for complex schema-defined types. In the future we may add schema annotations > of some sort to specify a more natural/efficient array type for the C > representations, but this should serve the majority of uses-cases for now. Series looks good to me. I'd drop patch 06/10 if it's not required for this series though.