From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uat6R-0004pv-Fp for qemu-devel@nongnu.org; Fri, 10 May 2013 15:35:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uat6Q-0000Eu-H4 for qemu-devel@nongnu.org; Fri, 10 May 2013 15:35:39 -0400 Received: from mail-ia0-x235.google.com ([2607:f8b0:4001:c02::235]:50529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uat6Q-0000En-Bz for qemu-devel@nongnu.org; Fri, 10 May 2013 15:35:38 -0400 Received: by mail-ia0-f181.google.com with SMTP id f27so5135123iae.12 for ; Fri, 10 May 2013 12:35:37 -0700 (PDT) Sender: fluxion Date: Fri, 10 May 2013 14:30:37 -0500 From: mdroth Message-ID: <20130510193037.GI13213@vm> References: <1368027096-12108-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368027096-12108-1-git-send-email-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: > I should have paid more attention to portability and error path cleanup > in the CVE-2013-2007 fix. > > (We continue to assume, like the rest of qemu code, that > qemu_set_cloexec() never fails internally. This should be a reasonable > assumption when the input fd is valid.) > > Laszlo Ersek (2): > qga: distinguish binary modes in "guest_file_open_modes" map > qga: unlink just created guest-file if fchmod() or fdopen() fails on > it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga > > qga/commands-posix.c | 25 +++++++++++++++++++------ > 1 files changed, 19 insertions(+), 6 deletions(-) >