From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UateL-0003i4-IV for qemu-devel@nongnu.org; Fri, 10 May 2013 16:10:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UateI-0003WZ-BP for qemu-devel@nongnu.org; Fri, 10 May 2013 16:10:41 -0400 Received: from mail-ia0-x22a.google.com ([2607:f8b0:4001:c02::22a]:56391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UateI-0003WV-66 for qemu-devel@nongnu.org; Fri, 10 May 2013 16:10:38 -0400 Received: by mail-ia0-f170.google.com with SMTP id k20so5173525iak.15 for ; Fri, 10 May 2013 13:10:37 -0700 (PDT) Sender: fluxion Date: Fri, 10 May 2013 15:09:26 -0500 From: mdroth Message-ID: <20130510200926.GJ13213@vm> References: <1368027096-12108-1-git-send-email-lersek@redhat.com> <20130510193037.GI13213@vm> <518D5037.8040605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <518D5037.8040605@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: > On 05/10/13 21:30, mdroth wrote: > > On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: > >> I should have paid more attention to portability and error path cleanup > >> in the CVE-2013-2007 fix. > >> > >> (We continue to assume, like the rest of qemu code, that > >> qemu_set_cloexec() never fails internally. This should be a reasonable > >> assumption when the input fd is valid.) > >> > >> Laszlo Ersek (2): > >> qga: distinguish binary modes in "guest_file_open_modes" map > >> qga: unlink just created guest-file if fchmod() or fdopen() fails on > >> it > > > > Thanks, applied to qga branch: > > > > https://github.com/mdroth/qemu/commits/qga > > Thanks! > > Can you reword the second commit to include Eric's R-b? > Sure, missed that one. Should be fixed in tree now. > > Thanks! > Laszlo >