From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uavpn-0006FP-FK for qemu-devel@nongnu.org; Fri, 10 May 2013 18:30:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uavpm-0005ER-97 for qemu-devel@nongnu.org; Fri, 10 May 2013 18:30:39 -0400 Received: from mail-ia0-x233.google.com ([2607:f8b0:4001:c02::233]:44915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uavpm-0005EE-3J for qemu-devel@nongnu.org; Fri, 10 May 2013 18:30:38 -0400 Received: by mail-ia0-f179.google.com with SMTP id h37so58665iak.24 for ; Fri, 10 May 2013 15:30:37 -0700 (PDT) Sender: fluxion Date: Fri, 10 May 2013 17:28:05 -0500 From: mdroth Message-ID: <20130510222805.GK13213@vm> References: <1368152462-13219-1-git-send-email-mdroth@linux.vnet.ibm.com> <1368152462-13219-5-git-send-email-mdroth@linux.vnet.ibm.com> <20130510101003.08580b76@redhat.com> <20130510163248.GH13213@vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130510163248.GH13213@vm> Subject: Re: [Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org On Fri, May 10, 2013 at 11:32:48AM -0500, mdroth wrote: > On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote: > > On Thu, 9 May 2013 21:20:56 -0500 > > Michael Roth wrote: > > > > > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs > > > qapi-types.c/qapi-visit.c > > > > > > Signed-off-by: Michael Roth > > > --- > > > Makefile | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/Makefile b/Makefile > > > index 7dc0204..9695c9d 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -178,7 +178,7 @@ Makefile: $(version-obj-y) $(version-lobj-y) > > > # Build libraries > > > > > > libqemustub.a: $(stub-obj-y) > > > -libqemuutil.a: $(util-obj-y) > > > +libqemuutil.a: $(util-obj-y) qapi-types.o qapi-visit.o > > > > Don't we want this in for 1.5? > > > > I don't think it's causing any issues currently since it's not causing > undefined reference errors upstream. users of libqemuutil that make use > of qemu-sockets seem to be pulling qapi-types/qapi-visit in through other > dependencies. > > I only noticed it because I was attempting to generate the native list > code via tests/Makefile and running into redefinition conflicts with > qapi-types.o/qapi-visit.o, then noticed the qemu-sockets.o issue when I > attempted to remove the qapi-types/qapi-visit dependency from > tests/test-visitor-serialization > > Now that we're generating the native list code from top-level Makefile, > it actually doesn't seem to be needed by this series anymore, so maybe > I'll pull it out for now. I think a better fix would be to have > qapi/Makefile.obj add these to $util-obj-y directly anyway. ^ this wasn't quite right, we do have a new dependency on qapi-types/qapi-visit in the visitor tests for native list types, so I've left this in place. > > > > > > > ###################################################################### > > > > > > @@ -215,10 +215,10 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py) > > > > > > qapi-types.c qapi-types.h :\ > > > $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-types.py $(qapi-py) > > > - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-types.py $(gen-out-type) -o "." < $<, " GEN $@") > > > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-types.py $(gen-out-type) -o "." -b < $<, " GEN $@") > > > qapi-visit.c qapi-visit.h :\ > > > $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-visit.py $(qapi-py) > > > - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-visit.py $(gen-out-type) -o "." < $<, " GEN $@") > > > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-visit.py $(gen-out-type) -o "." -b < $<, " GEN $@") > > > qmp-commands.h qmp-marshal.c :\ > > > $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py) > > > $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-commands.py $(gen-out-type) -m -o "." < $<, " GEN $@") > >