From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ubr2P-0004q5-8k for qemu-devel@nongnu.org; Mon, 13 May 2013 07:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ubr2O-0005Wa-1W for qemu-devel@nongnu.org; Mon, 13 May 2013 07:35:29 -0400 Sender: fluxion Date: Mon, 13 May 2013 06:33:13 -0500 From: mdroth Message-ID: <20130513113313.GL13213@vm> References: <1368027096-12108-1-git-send-email-lersek@redhat.com> <20130510193037.GI13213@vm> <518D5037.8040605@redhat.com> <20130510200926.GJ13213@vm> <518FC789.4080501@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <518FC789.4080501@suse.de> Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, Laszlo Ersek , qemu-devel@nongnu.org, qemu-stable On Sun, May 12, 2013 at 06:47:05PM +0200, Andreas Färber wrote: > Am 10.05.2013 22:09, schrieb mdroth: > > On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: > >> On 05/10/13 21:30, mdroth wrote: > >>> On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: > >>>> I should have paid more attention to portability and error path cleanup > >>>> in the CVE-2013-2007 fix. > >>>> > >>>> (We continue to assume, like the rest of qemu code, that > >>>> qemu_set_cloexec() never fails internally. This should be a reasonable > >>>> assumption when the input fd is valid.) > >>>> > >>>> Laszlo Ersek (2): > >>>> qga: distinguish binary modes in "guest_file_open_modes" map > >>>> qga: unlink just created guest-file if fchmod() or fdopen() fails on > >>>> it > >>> > >>> Thanks, applied to qga branch: > >>> > >>> https://github.com/mdroth/qemu/commits/qga > >> > >> Thanks! > >> > >> Can you reword the second commit to include Eric's R-b? > >> > > > > Sure, missed that one. Should be fixed in tree now. > > Shouldn't at least the unlinking be backported to stable as well? Yes, these are basically updates to the CVE fix, so I think they should all be applied to stable. I'll send PULL today so hopefully we can get them into 1.5 prior to patch freeze for 1.4.2. Otherwise I'll backport from the qga tree. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >