From: Stefan Hajnoczi <stefanha@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction
Date: Mon, 13 May 2013 16:53:22 +0200 [thread overview]
Message-ID: <20130513145322.GA27673@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5190E1BA.8080005@redhat.com>
On Mon, May 13, 2013 at 06:51:06AM -0600, Eric Blake wrote:
> On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> > There's no reason to restrict transactions to operations related to
> > block devices, so rename the type now before schema introspection stops
> > us from doing so.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > blockdev.c | 22 +++++++++++-----------
> > qapi-schema.json | 8 ++++----
> > 2 files changed, 15 insertions(+), 15 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> However,
>
> > #
> > # List of:
> > -# @BlockdevAction: information needed for the device snapshot
> > +# @TransactionAction: information needed for the device snapshot
>
> Is this comment now out of date?
kwolf: feel free to send a v2 and I'll replace what I merged.
prev parent reply other threads:[~2013-05-13 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 8:46 [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction Kevin Wolf
2013-05-13 12:35 ` Stefan Hajnoczi
2013-05-13 12:51 ` Eric Blake
2013-05-13 14:53 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513145322.GA27673@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).