From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ubu80-0008QJ-4n
	for qemu-devel@nongnu.org; Mon, 13 May 2013 10:53:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ubu7x-0006jD-7e
	for qemu-devel@nongnu.org; Mon, 13 May 2013 10:53:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20004)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ubu7w-0006j6-Vn
	for qemu-devel@nongnu.org; Mon, 13 May 2013 10:53:25 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4DErOqS026239
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 13 May 2013 10:53:24 -0400
Date: Mon, 13 May 2013 16:53:22 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130513145322.GA27673@stefanha-thinkpad.redhat.com>
References: <1368434774-13950-1-git-send-email-kwolf@redhat.com>
	<5190E1BA.8080005@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5190E1BA.8080005@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction ->
	TransactionAction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Mon, May 13, 2013 at 06:51:06AM -0600, Eric Blake wrote:
> On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> > There's no reason to restrict transactions to operations related to
> > block devices, so rename the type now before schema introspection stops
> > us from doing so.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  blockdev.c       | 22 +++++++++++-----------
> >  qapi-schema.json |  8 ++++----
> >  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> However,
> 
> >  #
> >  #  List of:
> > -#  @BlockdevAction: information needed for the device snapshot
> > +#  @TransactionAction: information needed for the device snapshot
> 
> Is this comment now out of date?

kwolf: feel free to send a v2 and I'll replace what I merged.