From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: seabios@seabios.org, lersek@redhat.com, qemu-devel@nongnu.org,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts
Date: Mon, 13 May 2013 23:29:41 +0300 [thread overview]
Message-ID: <20130513202941.GB4368@redhat.com> (raw)
In-Reply-To: <CAFEAcA9+JjAboZnbQPMAr1aycj=Uc_6=qEzFHgEh=+N5rbZN0g@mail.gmail.com>
On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote:
> On 13 May 2013 21:00, Michael S. Tsirkin <mst@redhat.com> wrote:
> > apic has its own version of bitops, with the
> > difference that it works on u32 and not long.
> > Add apic_ prefix to avoid namespace clashes.
>
> Wouldn't it be better to consolidate so we only have
> one set of bitops rather than a local set in this file?
>
> thanks
> -- PMM
Yes but I'd like this patchset to focus on acpi.
ATM including bitops in pc.h gives build errors.
Thus this trivial patch, can be tested by comparing binary.
Consolidation is better done in a separate patchset,
and would need more testing.
Any chance you can do this on top of this?
--
MST
next prev parent reply other threads:[~2013-05-13 20:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 20:00 [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-05-13 20:00 ` [Qemu-devel] [PATCH RFC 03/13] refer to FWCfgState explicitly Michael S. Tsirkin
2013-05-13 20:00 ` [Qemu-devel] [PATCH RFC 02/13] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h Michael S. Tsirkin
2013-05-13 20:08 ` Eric Blake
2013-05-13 20:00 ` [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts Michael S. Tsirkin
2013-05-13 20:22 ` Peter Maydell
2013-05-13 20:29 ` Michael S. Tsirkin [this message]
2013-05-13 20:00 ` [Qemu-devel] [PATCH RFC 04/13] fw_cfg: move typedef to qemu/typedefs.h Michael S. Tsirkin
2013-05-13 20:00 ` [Qemu-devel] [PATCH RFC 05/13] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 06/13] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 07/13] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 08/13] range: add Range structure Michael S. Tsirkin
2013-05-13 20:20 ` Peter Maydell
2013-05-14 7:55 ` Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 09/13] i386: add bios linker/loader Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 13/13] pc: reuse guest info for legacy fw cfg Michael S. Tsirkin
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info Michael S. Tsirkin
2013-05-13 20:23 ` Peter Maydell
2013-05-14 8:06 ` Michael S. Tsirkin
2013-05-14 9:32 ` Peter Maydell
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 12/13] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-05-13 20:27 ` Peter Maydell
2013-05-13 20:01 ` [Qemu-devel] [PATCH RFC 11/13] pc: pass PCI hole ranges to Guests Michael S. Tsirkin
2013-05-13 20:38 ` [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest Anthony Liguori
2013-05-14 1:54 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2013-05-14 9:29 ` [Qemu-devel] " Gerd Hoffmann
2013-05-14 9:38 ` Peter Maydell
2013-05-14 14:29 ` [Qemu-devel] [SeaBIOS] " David Woodhouse
2013-05-14 15:13 ` Peter Maydell
2013-05-14 13:26 ` [Qemu-devel] " Anthony Liguori
2013-05-14 13:53 ` Gerd Hoffmann
2013-05-14 14:40 ` Anthony Liguori
2013-05-14 11:58 ` Michael S. Tsirkin
2013-05-14 13:34 ` Anthony Liguori
2013-05-14 14:14 ` Michael S. Tsirkin
2013-05-15 6:38 ` [Qemu-devel] [SeaBIOS] " Gerd Hoffmann
2013-06-03 22:19 ` [Qemu-devel] " Jordan Justen
2013-06-03 23:12 ` Anthony Liguori
2013-06-04 4:14 ` Jordan Justen
2013-05-16 11:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513202941.GB4368@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).