From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcAFr-00066D-Ss for qemu-devel@nongnu.org; Tue, 14 May 2013 04:06:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcAFh-0003cu-9I for qemu-devel@nongnu.org; Tue, 14 May 2013 04:06:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcAFg-0003cb-V6 for qemu-devel@nongnu.org; Tue, 14 May 2013 04:06:29 -0400 Date: Tue, 14 May 2013 11:06:22 +0300 From: "Michael S. Tsirkin" Message-ID: <20130514080622.GA10214@redhat.com> References: <94d1bc6d9a1780d85773c02306ca469f30bd8c93.1368474222.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: seabios@seabios.org, lersek@redhat.com, qemu-devel@nongnu.org, Anthony Liguori On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: > On 13 May 2013 21:01, Michael S. Tsirkin wrote: > > This fills in guest info table with misc > > information of interest to the guest. > > Will be used by ACPI table generation code. > > Bunch of coding style violations in this patch which will > need fixing at some point in the RFC->patch process. > > thanks > -- PMM I went over it again and found one: + if (ram_size <= 0x80000000) + guest_info->pci_info.w32.begin = 0x80000000; + else if (ram_size <= 0xc0000000) + guest_info->pci_info.w32.begin = 0xc0000000; + else + guest_info->pci_info.w32.begin = 0xe0000000; should use {}. One is not a bunch so I obviously missed some - it might be helpful if you pointed them out. Thanks, -- MST