From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UcAT3-0000zQ-4A
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:20:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UcAT0-00085r-Ui
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:20:17 -0400
Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:43300)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UcAMY-0005mk-PH
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:13:34 -0400
Received: by mail-we0-f180.google.com with SMTP id n5so184046wev.11
	for <qemu-devel@nongnu.org>; Tue, 14 May 2013 01:13:34 -0700 (PDT)
Date: Tue, 14 May 2013 10:13:31 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130514081331.GE3632@stefanha-thinkpad.redhat.com>
References: <1368498390-20738-1-git-send-email-famz@redhat.com>
	<1368498390-20738-5-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1368498390-20738-5-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, May 14, 2013 at 10:26:23AM +0800, Fam Zheng wrote:
> +    if (!strncmp(s->url, "http://", strlen("http://")) && !s->accept_range) {
> +        strncpy(state->errmsg, "Server not supporting range.", CURL_ERROR_SIZE);

Please use pstrcpy(), it always NUL-terminates.  strncpy(3) does not
when the buffer size is reached.

Also, what happens when the URL is given in uppercase?
HTTP://GOOGLE.COM/