From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read
Date: Tue, 14 May 2013 10:22:53 +0200 [thread overview]
Message-ID: <20130514082253.GG3632@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1368498390-20738-1-git-send-email-famz@redhat.com>
On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote:
> - CURLDataCache holds the user data read from libcurl, it is in a list
> ordered by access, the used cache is moved to list head on access, so
> the tail element is freed first. BDRVCURLState.cache_quota is the
> threshold to start freeing cache.
Can you explain the need for a cache?
The guest kernel already does readahead if it wants to. It can be tuned
from inside the guest if performance doesn't meet expectations. The
block/curl.c-specific cache cannot be tuned from the guest.
Stefan
next prev parent reply other threads:[~2013-05-14 8:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 2:26 [Qemu-devel] [PATCH v2 00/11] curl: fix curl read Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-14 7:59 ` Stefan Hajnoczi
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro Fam Zheng
2013-05-14 8:04 ` Stefan Hajnoczi
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 03/11] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open Fam Zheng
2013-05-14 8:13 ` Stefan Hajnoczi
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 05/11] curl: add timer to BDRVCURLState Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 06/11] curl: introduce CURLDataCache Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 07/11] curl: make use of CURLDataCache Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 08/11] curl: use list to store CURLState Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close Fam Zheng
2013-05-14 8:20 ` Stefan Hajnoczi
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 10/11] curl: add cache quota Fam Zheng
2013-05-14 2:26 ` [Qemu-devel] [PATCH v2 11/11] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-14 8:22 ` Stefan Hajnoczi [this message]
2013-05-14 8:50 ` [Qemu-devel] [PATCH v2 00/11] curl: fix curl read Fam Zheng
2013-05-15 3:46 ` Fam Zheng
2013-05-15 7:56 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514082253.GG3632@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).