From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcAVh-0004M2-6O for qemu-devel@nongnu.org; Tue, 14 May 2013 04:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcAVf-0000Il-1F for qemu-devel@nongnu.org; Tue, 14 May 2013 04:23:01 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:61918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcAVe-0000IJ-Rj for qemu-devel@nongnu.org; Tue, 14 May 2013 04:22:58 -0400 Received: by mail-wi0-f174.google.com with SMTP id c10so1745549wiw.7 for ; Tue, 14 May 2013 01:22:58 -0700 (PDT) Date: Tue, 14 May 2013 10:22:53 +0200 From: Stefan Hajnoczi Message-ID: <20130514082253.GG3632@stefanha-thinkpad.redhat.com> References: <1368498390-20738-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368498390-20738-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote: > - CURLDataCache holds the user data read from libcurl, it is in a list > ordered by access, the used cache is moved to list head on access, so > the tail element is freed first. BDRVCURLState.cache_quota is the > threshold to start freeing cache. Can you explain the need for a cache? The guest kernel already does readahead if it wants to. It can be tuned from inside the guest if performance doesn't meet expectations. The block/curl.c-specific cache cannot be tuned from the guest. Stefan