From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UcAqQ-000132-1V
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:44:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UcAqJ-0007qZ-4j
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:44:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49190)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UcAqI-0007q1-Qe
	for qemu-devel@nongnu.org; Tue, 14 May 2013 04:44:19 -0400
Date: Tue, 14 May 2013 10:44:14 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130514084414.GE8739@stefanha-thinkpad.redhat.com>
References: <1367221335-22777-1-git-send-email-stefanha@redhat.com>
	<1367221335-22777-3-git-send-email-stefanha@redhat.com>
	<20130508124859.GH3093@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130508124859.GH3093@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Wenchao Xia <xiawenc@linux.vnet.ibm.com>, imain@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com

On Wed, May 08, 2013 at 02:49:00PM +0200, Kevin Wolf wrote:
> Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben:
> > @block-backup
> > 
> > Start a point-in-time copy of a block device to a new destination.  The
> > status of ongoing block backup operations can be checked with
> > query-block-jobs.  The operation can be stopped before it has completed using
> > the block-job-cancel command.
> > 
> > @device: the name of the device whose writes should be mirrored.
> > 
> > @target: the target of the new image. If the file exists, or if it
> >          is a device, the existing file/device will be used as the new
> >          destination.  If it does not exist, a new file will be created.
> > 
> > @format: #optional the format of the new destination, default is to
> >          probe if @mode is 'existing', else the format of the source
> > 
> > @mode: #optional whether and how QEMU should create a new image, default is
> >        'absolute-paths'.
> > 
> > @speed: #optional the maximum speed, in bytes per second
> > 
> > Returns: nothing on success
> >          If @device is not a valid block device, DeviceNotFound
> > 
> > Since 1.6
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> drive-backup would probably be a more consistent naming. We would then
> still have block-backup for a future low-level command that doesn't
> create everything by itself but takes an existing BlockDriverState (e.g.
> created by blockdev-add).
> 
> We should also make it transactionable from the beginning, as we don't
> have schema introspection yet. This way we allow to assume that if the
> standalone command exists, the transaction subcommand exists as well.

Sounds good.  I'll make both changes.

Stefan