From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ucbax-00041D-ST for qemu-devel@nongnu.org; Wed, 15 May 2013 09:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ucbaw-0008H8-HD for qemu-devel@nongnu.org; Wed, 15 May 2013 09:18:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ucbav-0008H2-Uu for qemu-devel@nongnu.org; Wed, 15 May 2013 09:18:14 -0400 Date: Wed, 15 May 2013 09:17:46 -0400 From: Luiz Capitulino Message-ID: <20130515091746.68ee3f4d@redhat.com> In-Reply-To: <1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: akong@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org On Fri, 10 May 2013 17:45:59 -0500 Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained f= rom: > git://github.com/mdroth/qemu.git qapi-native-lists >=20 > Sending this now since a number of series have popped up in the past that > wanted this, and Amos has some pending patches (query-mac-tables) that re= ly > on this as well. >=20 > These patches add support for specifying lists of native qapi types > (int/bool/str/number/int8/uint8/etc) like so: >=20 > { 'type': 'foo', > 'data': { 'bar': ['int'] }} >=20 > for a 'bar' field that is a list of type 'int', >=20 > { 'type': 'foo2', > 'data': { 'bar2': ['str'] }} >=20 > for a 'bar2' field that is a list of type 'str', and so on. >=20 > This uses linked list types for the native C representations, just as we = do > for complex schema-defined types. In the future we may add schema annotat= ions > of some sort to specify a more natural/efficient array type for the C > representations, but this should serve the majority of uses-cases for now. I'm getting a build breakage when building all targets: In file included from /home/lcapitulino/work/src/upstream/qmp-unstable/targ= et-i386/cpu.c:34:0: ../qapi-visit.h:30:38: error: unknown type name =E2=80=98int8List=E2=80=99 ../qapi-visit.h:31:39: error: unknown type name =E2=80=98int16List=E2=80=99 ../qapi-visit.h:32:39: error: unknown type name =E2=80=98int32List=E2=80=99 ../qapi-visit.h:33:39: error: unknown type name =E2=80=98int64List=E2=80=99 ../qapi-visit.h:34:39: error: unknown type name =E2=80=98uint8List=E2=80=99 ../qapi-visit.h:35:40: error: unknown type name =E2=80=98uint16List=E2=80=99 ../qapi-visit.h:36:40: error: unknown type name =E2=80=98uint32List=E2=80=99 ../qapi-visit.h:37:40: error: unknown type name =E2=80=98uint64List=E2=80=99 make[1]: *** [target-i386/cpu.o] Error 1 make: *** [subdir-i386-softmmu] Error 2 make: *** Waiting for unfinished jobs.... In file included from /home/lcapitulino/work/src/upstream/qmp-unstable/targ= et-i386/cpu.c:34:0: ../qapi-visit.h:30:38: error: unknown type name =E2=80=98int8List=E2=80=99 ../qapi-visit.h:31:39: error: unknown type name =E2=80=98int16List=E2=80=99 ../qapi-visit.h:32:39: error: unknown type name =E2=80=98int32List=E2=80=99 ../qapi-visit.h:33:39: error: unknown type name =E2=80=98int64List=E2=80=99 ../qapi-visit.h:34:39: error: unknown type name =E2=80=98uint8List=E2=80=99 ../qapi-visit.h:35:40: error: unknown type name =E2=80=98uint16List=E2=80=99 ../qapi-visit.h:36:40: error: unknown type name =E2=80=98uint32List=E2=80=99 ../qapi-visit.h:37:40: error: unknown type name =E2=80=98uint64List=E2=80=99 make[1]: *** [target-i386/cpu.o] Error 1 make: *** [subdir-x86_64-softmmu] Error 2