From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uccsb-00064f-4d for qemu-devel@nongnu.org; Wed, 15 May 2013 10:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UccsU-0001d8-RK for qemu-devel@nongnu.org; Wed, 15 May 2013 10:40:33 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:46516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UccsU-0001cw-N2 for qemu-devel@nongnu.org; Wed, 15 May 2013 10:40:26 -0400 Received: by mail-oa0-f48.google.com with SMTP id i4so2255338oah.35 for ; Wed, 15 May 2013 07:40:26 -0700 (PDT) Sender: fluxion Date: Wed, 15 May 2013 09:32:37 -0500 From: mdroth Message-ID: <20130515143237.GM13213@vm> References: <1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com> <20130515091746.68ee3f4d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130515091746.68ee3f4d@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > On Fri, 10 May 2013 17:45:59 -0500 > Michael Roth wrote: > > > These patches apply on top of qemu.git master, and can also be obtained from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending this now since a number of series have popped up in the past that > > wanted this, and Amos has some pending patches (query-mac-tables) that rely > > on this as well. > > > > These patches add support for specifying lists of native qapi types > > (int/bool/str/number/int8/uint8/etc) like so: > > > > { 'type': 'foo', > > 'data': { 'bar': ['int'] }} > > > > for a 'bar' field that is a list of type 'int', > > > > { 'type': 'foo2', > > 'data': { 'bar2': ['str'] }} > > > > for a 'bar2' field that is a list of type 'str', and so on. > > > > This uses linked list types for the native C representations, just as we do > > for complex schema-defined types. In the future we may add schema annotations > > of some sort to specify a more natural/efficient array type for the C > > representations, but this should serve the majority of uses-cases for now. > > I'm getting a build breakage when building all targets: Hmm, tested all target builds and didn't/don't see any issues. Is this a clean build? Can you confirm whether or not int8List/etc are declared in qapi-types.h in your current build dir? If they're not in there the file is stale and not being regenerated for some reason. Which would be weird since qapi-visit.h seems to be getting regenerated. If they *are* there might be some kind of race in the QAPI build system, because I think we rely on qapi-types.h/qapi-visit.h coming from GENERATED_HEADERS, but otherwise being treated as parallelizable. Really, qapi-types.h should be a dependancy of all qapi-visit.h users, and I don't see that reflected in the Makefile unless I'm missing something. > > In file included from /home/lcapitulino/work/src/upstream/qmp-unstable/target-i386/cpu.c:34:0: > ../qapi-visit.h:30:38: error: unknown type name ‘int8List’ > ../qapi-visit.h:31:39: error: unknown type name ‘int16List’ > ../qapi-visit.h:32:39: error: unknown type name ‘int32List’ > ../qapi-visit.h:33:39: error: unknown type name ‘int64List’ > ../qapi-visit.h:34:39: error: unknown type name ‘uint8List’ > ../qapi-visit.h:35:40: error: unknown type name ‘uint16List’ > ../qapi-visit.h:36:40: error: unknown type name ‘uint32List’ > ../qapi-visit.h:37:40: error: unknown type name ‘uint64List’ > make[1]: *** [target-i386/cpu.o] Error 1 > make: *** [subdir-i386-softmmu] Error 2 > make: *** Waiting for unfinished jobs.... > In file included from /home/lcapitulino/work/src/upstream/qmp-unstable/target-i386/cpu.c:34:0: > ../qapi-visit.h:30:38: error: unknown type name ‘int8List’ > ../qapi-visit.h:31:39: error: unknown type name ‘int16List’ > ../qapi-visit.h:32:39: error: unknown type name ‘int32List’ > ../qapi-visit.h:33:39: error: unknown type name ‘int64List’ > ../qapi-visit.h:34:39: error: unknown type name ‘uint8List’ > ../qapi-visit.h:35:40: error: unknown type name ‘uint16List’ > ../qapi-visit.h:36:40: error: unknown type name ‘uint32List’ > ../qapi-visit.h:37:40: error: unknown type name ‘uint64List’ > make[1]: *** [target-i386/cpu.o] Error 1 > make: *** [subdir-x86_64-softmmu] Error 2 >