From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ucsep-00073R-0f
	for qemu-devel@nongnu.org; Thu, 16 May 2013 03:31:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ucsek-0004UG-K3
	for qemu-devel@nongnu.org; Thu, 16 May 2013 03:31:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46082)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Ucsek-0004U2-DS
	for qemu-devel@nongnu.org; Thu, 16 May 2013 03:31:18 -0400
Date: Thu, 16 May 2013 09:31:14 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130516073114.GC1597@stefanha-thinkpad.redhat.com>
References: <1368628476-19622-1-git-send-email-stefanha@redhat.com>
	<1368628476-19622-4-git-send-email-stefanha@redhat.com>
	<5193DC57.5050203@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5193DC57.5050203@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, xiawenc@linux.vnet.ibm.com

On Wed, May 15, 2013 at 01:04:55PM -0600, Eric Blake wrote:
> On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote:
> > @drive-backup
> > 
> > Start a point-in-time copy of a block device to a new destination.  The
> > status of ongoing drive-backup operations can be checked with
> > query-block-jobs where the BlockJobInfo.type field has the value 'backup'.
> > The operation can be stopped before it has completed using the
> > block-job-cancel command.
> > 
> 
> > +++ b/qmp-commands.hx
> > @@ -912,6 +912,12 @@ EQMP
> >      },
> >  
> >      {
> > +        .name       = "drive-backup",
> > +        .args_type  = "device:B,target:s,speed:i?,mode:s?,format:s?",
> > +        .mhandler.cmd_new = qmp_marshal_input_drive_backup,
> > +    },
> 
> No example?  But I'm not going to block this patch because of that.

I'll add an example in v4.