From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdFKv-0003EH-Av for qemu-devel@nongnu.org; Fri, 17 May 2013 03:44:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdFKp-0004mP-Pd for qemu-devel@nongnu.org; Fri, 17 May 2013 03:44:21 -0400 Received: from [222.73.24.84] (port=18495 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdFKp-0004hu-Bh for qemu-devel@nongnu.org; Fri, 17 May 2013 03:44:15 -0400 Date: Fri, 17 May 2013 15:43:25 +0800 From: Hu Tao Message-ID: <20130517074324.GH20302@localhost.localdomain> References: <6020fa77df1ada026222d876fdadab0fbe746f41.1365143012.git.hutao@cn.fujitsu.com> <5195D543.70005@de.ibm.com> MIME-Version: 1.0 In-Reply-To: <5195D543.70005@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: [Qemu-devel] [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Peter Maydell , Gleb Natapov , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel , Markus Armbruster , Blue Swirl , Orit Wasserman , Juan Quintela , Alexander Graf , Andrew Jones , Alex Williamson , Sasha Levin , Stefan Hajnoczi , Luiz Capitulino , KAMEZAWA Hiroyuki , Anthony Liguori , Marcelo Tosatti , Paolo Bonzini On Fri, May 17, 2013 at 08:59:15AM +0200, Christian Borntraeger wrote: > On 05/04/13 08:36, Hu Tao wrote: > > The guest will be in this state when it is panicked. > > > > Signed-off-by: Wen Congyang > > Signed-off-by: Hu Tao > > This actually broken virsh dump without --memory-only: > > ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate' > > > (virsh dump without memory-only falls back to migrate "exec: cat > dumpfile") > > Christian This patch should fix the problem: >>From d470feefe3d320c43c1fb2eb43457a99b96cdc98 Mon Sep 17 00:00:00 2001 From: Hu Tao Date: Fri, 17 May 2013 15:39:07 +0800 Subject: [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE This fixes a problem that after guest panic happens, virsh dump without --memory-only fails: ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate' Reported-by: Christian Borntraeger Signed-off-by: Hu Tao --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index be0a93c..59dc0b4 100644 --- a/vl.c +++ b/vl.c @@ -609,6 +609,7 @@ static const RunStateTransition runstate_transitions_def[] = { { RUN_STATE_WATCHDOG, RUN_STATE_FINISH_MIGRATE }, { RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED }, + { RUN_STATE_GUEST_PANICKED, RUN_STATE_FINISH_MIGRATE }, { RUN_STATE_MAX, RUN_STATE_MAX }, }; -- 1.8.1.4