From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdQvS-0000jd-Bq for qemu-devel@nongnu.org; Fri, 17 May 2013 16:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdQvN-0000U8-Nx for qemu-devel@nongnu.org; Fri, 17 May 2013 16:06:50 -0400 Received: from mail-ia0-x232.google.com ([2607:f8b0:4001:c02::232]:38876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdQvN-0000U3-JJ for qemu-devel@nongnu.org; Fri, 17 May 2013 16:06:45 -0400 Received: by mail-ia0-f178.google.com with SMTP id i9so5255235iad.37 for ; Fri, 17 May 2013 13:06:45 -0700 (PDT) Sender: fluxion Date: Fri, 17 May 2013 15:06:12 -0500 From: mdroth Message-ID: <20130517200612.GE2441@vm> References: <1368225970-28506-1-git-send-email-mdroth@linux.vnet.ibm.com> <20130515091746.68ee3f4d@redhat.com> <20130515143237.GM13213@vm> <20130515110427.5b8b4fbf@redhat.com> <20130515174224.GN13213@vm> <20130515140558.7687e36f@redhat.com> <20130515191309.GB23880@vm> <5194B726.6050201@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5194B726.6050201@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: akong@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On Thu, May 16, 2013 at 12:38:30PM +0200, Laszlo Ersek wrote: > On 05/15/13 21:13, mdroth wrote: > > On Wed, May 15, 2013 at 02:05:58PM -0400, Luiz Capitulino wrote: > >> On Wed, 15 May 2013 12:42:24 -0500 > >> mdroth wrote: > > >>> The only way I've managed to reproduce this is by having a stale > >>> qapi-types.h hanging around in $SRC_DIR while i'm building in a > >>> different $BUILD_DIR. Can you confirm that's not what's happening here? > >> > >> Yes, it was :( I had an old qapi-types.h in $SRC_DIR, but was building > >> in a different $BUILD_DIR. I am really sorry for having wasted your time > >> on this. > >> > >> I've applied this series to qmp-next branch, but I have no idea how I ended > >> up with a qapi-types.h file in $SRC_DIR. I have an alias to build qemu that > >> I use for several months now... > >> > > > > No problem, only thought to check that scenario because it happens to me > > all the time :) > > Side question: what's a common use case for a separate $BUILD_DIR? I > just use "git clean -fdx" in $SRC_DIR instead of "make clean". The need > to reconfigure (and to regenerate my tags file from scratch) is a small > price to pay for the peace of mind. I also do it for peace of mind, but I'm not particularly disciplined about logging all my changes/new files into git as i go, so it's nice to be able to do a clean build even when my $SRC_DIR is littered with abandoned code/files/etc by simply wiping out the build dir. I also have a number of situations where the resulting builds need to be kept around for a while. For example I have build directories for v1.1->v1.5 that I keep around for migration testing, other builds for general usage, and a multitude of temp builds i might create to compare upstream against a test/stable/development build. I could use `make install` with an install prefix for this but for me it's quicker to just use the binaries within the build directory. Wasn't aware of `git clean` though, always just tried to make due with `git reset --hard` + rm but that can get tedious at times. > > Thanks > Laszlo >