From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeBMs-00061C-LY for qemu-devel@nongnu.org; Sun, 19 May 2013 17:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeBMr-0001oW-LF for qemu-devel@nongnu.org; Sun, 19 May 2013 17:42:14 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeBMr-0001oO-E6 for qemu-devel@nongnu.org; Sun, 19 May 2013 17:42:13 -0400 Date: Sun, 19 May 2013 23:42:07 +0200 From: Aurelien Jarno Message-ID: <20130519214207.GF5002@ohm.aurel32.net> References: <1368827481-20434-1-git-send-email-kcy@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1368827481-20434-1-git-send-email-kcy@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] linux-user: Fix MIPS16/microMIPS signal handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kwok Cheung Yeung Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org On Fri, May 17, 2013 at 02:51:19PM -0700, Kwok Cheung Yeung wrote: > These patches fix various issues related to signal handling in user mode > emulation for the MIPS architecture. > > - When a MIPS16/microMIPS signal handler is called, the program segfaults > because the PC is set to an invalid address. > - When returning from a signal handler, the ISA mode is not set to that > of the resume instruction. > - When the faulting instruction is in a branch delay slot, the resume > address is set to that of the instruction rather than the branch, > resulting in incorrect behaviour. The flag indicating that the > instruction is in a delay slot is also not cleared. > > v1 -> v2: > - Add fixes for signal return and delay slot instructions > - Refactor code > > Kwok Cheung Yeung (2): > linux-user: Fix MIPS ISA transitions during signal handling > linux-user: Save the correct resume address for MIPS signal handling > > linux-user/signal.c | 16 +++++++++++++++- > target-mips/cpu.h | 1 + > target-mips/helper.c | 4 ++-- > 3 files changed, 18 insertions(+), 3 deletions(-) > Thanks, both queued for 1.6. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net