From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeQPn-0000m7-Iv for qemu-devel@nongnu.org; Mon, 20 May 2013 09:46:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeQPh-00062C-By for qemu-devel@nongnu.org; Mon, 20 May 2013 09:46:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeQPh-000625-3m for qemu-devel@nongnu.org; Mon, 20 May 2013 09:46:09 -0400 Date: Mon, 20 May 2013 16:46:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20130520134624.GA12441@redhat.com> References: <20130520081814.GA8162@redhat.com> <519A0089.40109@redhat.com> <20130520121256.GA9175@redhat.com> <519A2795.9050608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519A2795.9050608@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Amos Kong , Andreas =?iso-8859-1?Q?F=E4rber?= , KONRAD Frederic On Mon, May 20, 2013 at 03:39:33PM +0200, Paolo Bonzini wrote: > Il 20/05/2013 15:36, Michael S. Tsirkin ha scritto: > > On Mon, May 20, 2013 at 12:52:57PM +0200, Paolo Bonzini wrote: > >> Il 20/05/2013 10:18, Michael S. Tsirkin ha scritto: > >>> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h > >>> index beeead7..b315ac9 100644 > >>> --- a/include/hw/virtio/virtio-net.h > >>> +++ b/include/hw/virtio/virtio-net.h > >>> @@ -31,6 +31,8 @@ > >>> /* The feature bitmap for virtio net */ > >>> #define VIRTIO_NET_F_CSUM 0 /* Host handles pkts w/ partial csum */ > >>> #define VIRTIO_NET_F_GUEST_CSUM 1 /* Guest handles pkts w/ partial csum */ > >>> +#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Control channel offload > >>> + * configuration support */ > >> > >> Any reason not to use 22? > > > > There are several > > - 22 is already used by VIRTIO_NET_F_MQ > > Oops, old copy here. > > > - guest drivers (in development) and spec upstream both use 2 > > > > I don't know for sure, sorry. > > BTW please send questions on virtio spec on virtio > > mailing list, not here. > > I could not find the message with the spec update, now I found it. > It > was a bit weird because the series had one patch for virtio-spec and one > for QEMU. > > Paolo It's now in Rusty's git tree: https://github.com/rustyrussell/virtio-spec -- MST