From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeT2u-0003fx-DI for qemu-devel@nongnu.org; Mon, 20 May 2013 12:34:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeT2p-0007RH-Lr for qemu-devel@nongnu.org; Mon, 20 May 2013 12:34:48 -0400 Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:33870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeSoy-0002kU-BT for qemu-devel@nongnu.org; Mon, 20 May 2013 12:20:24 -0400 Received: by mail-ob0-f170.google.com with SMTP id er7so7349552obc.29 for ; Mon, 20 May 2013 09:20:20 -0700 (PDT) Sender: fluxion Date: Mon, 20 May 2013 11:15:35 -0500 From: mdroth Message-ID: <20130520161535.GF2441@vm> References: <1368851513-20550-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368851513-20550-1-git-send-email-lersek@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/6] local state directory fixes for win32 qga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org On Sat, May 18, 2013 at 06:31:47AM +0200, Laszlo Ersek wrote: > Qouting patch 2/6: > > > Since commit 39097daf ("qemu-ga: use key-value store to avoid > > recycling fd handles after restart") we've relied on the state > > directory for the fd handles' key-value store. Even though we don't > > support the guest-file-* commands on win32 yet, the key-value store is > > written, and it's the first use of the state directory on win32. We > > should have a sensible default for its location. > > Motivated by RHBZ#962669. > > I've perpetrated this in the second half of a Friday->Sunday > all-nighter, so be gentle. Thanks. :) I still need to do some testing to make sure our w32 incantations are doing what we expect, but I reviewed your series and it looks good to me. Also, thanks to 4/7 and the fact that the keystore isn't currently used on w32, we should be able to switch existing users to the new default state directory without any problems. Series: Reviewed-by: Michael Roth > > Laszlo Ersek (6): > osdep: add qemu_get_local_state_pathname() > qga: determine default state dir and pidfile dynamically > configure: don't save any fixed local_statedir for win32 > qga: create state directory on win32 > qga: remove undefined behavior in ga_install_service() > qga: save state directory in ga_install_service() > > configure | 12 +++++++--- > include/qemu/osdep.h | 11 +++++++++ > qga/service-win32.h | 3 +- > qga/main.c | 57 +++++++++++++++++++++++++++++++++++++++++++------ > qga/service-win32.c | 25 ++++++++++++++-------- > util/oslib-posix.c | 9 ++++++++ > util/oslib-win32.c | 22 +++++++++++++++++++ > 7 files changed, 118 insertions(+), 21 deletions(-) >