From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
Date: Wed, 22 May 2013 00:46:45 +0300 [thread overview]
Message-ID: <20130521214645.GA8863@redhat.com> (raw)
Once in a while make gets killed and doesn't
clean up partial object files after it.
Result is nasty errors from link.
This hack checks object is well formed before linking,
and rebuilds it if not.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Is below useful for others?
Makefile.target | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Makefile.target b/Makefile.target
index ce4391f..4dddee5 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,3 +191,10 @@ endif
GENERATED_HEADERS += config-target.h
Makefile: $(GENERATED_HEADERS)
+
+.SECONDEXPANSION:
+
+.PHONY: CORRUPTBINARY
+
+$(all-obj-y): % : $$(if $$(shell size %), , CORRUPTBINARY)
+
--
MST
next reply other threads:[~2013-05-21 21:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 21:46 Michael S. Tsirkin [this message]
2013-05-21 22:01 ` [Qemu-devel] [PATCH] makefile: detect corrupted elf files Peter Maydell
2013-05-21 22:09 ` Michael S. Tsirkin
2013-05-22 7:44 ` Markus Armbruster
2013-05-22 8:37 ` Michael S. Tsirkin
2013-05-22 8:38 ` Peter Maydell
2013-05-22 8:43 ` Paolo Bonzini
2013-05-22 8:52 ` Michael S. Tsirkin
2013-05-22 9:22 ` Paolo Bonzini
2013-05-22 9:42 ` Michael S. Tsirkin
2013-05-22 10:40 ` Paolo Bonzini
2013-05-22 10:50 ` Michael S. Tsirkin
2013-05-22 10:51 ` Paolo Bonzini
2013-05-22 11:09 ` Michael S. Tsirkin
2013-05-22 11:12 ` Paolo Bonzini
2013-05-22 11:35 ` Michael S. Tsirkin
2013-05-25 17:32 ` Blue Swirl
2013-05-26 7:35 ` Michael S. Tsirkin
2013-05-26 9:12 ` Peter Maydell
2013-05-26 12:31 ` Michael S. Tsirkin
2013-05-26 12:48 ` Stefan Weil
2013-05-26 13:11 ` Michael S. Tsirkin
2013-05-26 13:36 ` Peter Maydell
2013-05-26 13:40 ` Michael S. Tsirkin
2013-05-26 18:20 ` Blue Swirl
2013-05-26 18:24 ` Michael S. Tsirkin
2013-05-26 19:28 ` Blue Swirl
2013-05-26 20:15 ` Michael S. Tsirkin
2013-05-26 20:29 ` Blue Swirl
2013-05-26 20:55 ` Michael S. Tsirkin
2013-05-28 10:33 ` Michael S. Tsirkin
2013-05-26 21:03 ` Anthony Liguori
2013-05-22 8:46 ` Michael S. Tsirkin
2013-05-22 9:48 ` Stefan Hajnoczi
2013-05-22 10:00 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521214645.GA8863@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).