From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ueuju-0002gy-Jo
	for qemu-devel@nongnu.org; Tue, 21 May 2013 18:09:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ueujq-0002eD-Kn
	for qemu-devel@nongnu.org; Tue, 21 May 2013 18:09:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Ueujq-0002dw-Ch
	for qemu-devel@nongnu.org; Tue, 21 May 2013 18:08:58 -0400
Date: Wed, 22 May 2013 01:09:17 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130521220917.GA803@redhat.com>
References: <20130521214645.GA8863@redhat.com>
	<CAFEAcA9QfHgM8KaBFOmHvDPur=8M4YPLrnBvJsZGWG6NodaQoA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9QfHgM8KaBFOmHvDPur=8M4YPLrnBvJsZGWG6NodaQoA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Tue, May 21, 2013 at 11:01:05PM +0100, Peter Maydell wrote:
> On 21 May 2013 22:46, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Once in a while make gets killed and doesn't
> > clean up partial object files after it.
> > Result is nasty errors from link.
> > This hack checks object is well formed before linking,
> > and rebuilds it if not.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Is below useful for others?
> 
> Seems to me like this is just working around a make bug:
> it is supposed to delete the partial object if it gets
> killed.

It can't if it gets killed by kill -9 or e.g. OOM killer
(or OS reboot).

> > +$(all-obj-y): % : $$(if $$(shell size %), , CORRUPTBINARY)
> 
> If we do do this, we probably ought to be running the
> cross-prefix version of size, not the host version.

Good point, thanks.

> thanks
> -- PMM