From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf4mC-00062J-Rz for qemu-devel@nongnu.org; Wed, 22 May 2013 04:52:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf4mA-0006Db-9j for qemu-devel@nongnu.org; Wed, 22 May 2013 04:52:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf4m9-0006DQ-UM for qemu-devel@nongnu.org; Wed, 22 May 2013 04:52:02 -0400 Date: Wed, 22 May 2013 11:52:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20130522085219.GF7993@redhat.com> References: <20130521214645.GA8863@redhat.com> <20130521220917.GA803@redhat.com> <87obc34fy3.fsf@blackfin.pond.sub.org> <20130522083732.GD7993@redhat.com> <519C8541.6060605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519C8541.6060605@redhat.com> Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Blue Swirl On Wed, May 22, 2013 at 10:43:45AM +0200, Paolo Bonzini wrote: > Il 22/05/2013 10:38, Peter Maydell ha scritto: > > On 22 May 2013 09:37, Michael S. Tsirkin wrote: > >> It's my fault for running -rc kernels all the time I guess, I get > >> crashes kind of often, and losing more time on make clean > >> on top of reboot annoys me. > >> But we actually could make it robust, even against OS crash. Output to a > >> temporary file then rename. This hack won't be needed then. > > > > I think that would be better implemented in the compiler/linker :-) > > Alternatively, stop doing compiles on horribly unstable kernels. > > Any filesystem with delayed writes can do this if you have a power loss. > > But I agree that this patch doesn't solve the problem. For example, if > you get stale files in the ccache directory even zapping the build > directory won't do. > > Paolo The fix is simple here: don't use ccache. I don't. In fact, from what I saw people use ccache to work around makefile bugs, so they can do make clean; make and have it finish quickly. Any other examples? -- MST