From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
Date: Wed, 22 May 2013 14:09:22 +0300 [thread overview]
Message-ID: <20130522110922.GC5643@redhat.com> (raw)
In-Reply-To: <519CA33E.9010109@redhat.com>
On Wed, May 22, 2013 at 12:51:42PM +0200, Paolo Bonzini wrote:
> Il 22/05/2013 12:50, Michael S. Tsirkin ha scritto:
> > On Wed, May 22, 2013 at 12:40:23PM +0200, Paolo Bonzini wrote:
> >> Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto:
> >>> On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote:
> >>>> Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto:
> >>>>> The fix is simple here: don't use ccache. I don't.
> >>>>>
> >>>>> In fact, from what I saw people use ccache to work around makefile bugs,
> >>>>> so they can do make clean; make and have it finish quickly.
> >>>>>
> >>>>> Any other examples?
> >>>>
> >>>> Testing configure patches should be done (also) from a clean build
> >>>> directory, for example.
> >>>
> >>> In fact, relying on make clean for testing the build
> >>> system is a mistake. It's easy for it to forget to
> >>> remove some temporary file. You really should do
> >>> a clean clone.
> >>
> >> Yes, I use a clean clone (and a clean build directory for each patch),
> >> _hence_ ccache helps reducing test times.
> >
> > I see, this workflow is the exact reverse of mine:
> >
> > I do as much as possible in a single tree so I
> > rely on the makefile dependencies to be correct
> > to rebuild the right things.
>
> Usually I do the same---I just do slightly more thorough testing for
> configure patches.
>
> Paolo
I've no idea what happens with ccache on a crash by the way.
It's possible that it's careful to do renames in order to not leave
corrupted output files behind.
--
MST
next prev parent reply other threads:[~2013-05-22 11:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 21:46 [Qemu-devel] [PATCH] makefile: detect corrupted elf files Michael S. Tsirkin
2013-05-21 22:01 ` Peter Maydell
2013-05-21 22:09 ` Michael S. Tsirkin
2013-05-22 7:44 ` Markus Armbruster
2013-05-22 8:37 ` Michael S. Tsirkin
2013-05-22 8:38 ` Peter Maydell
2013-05-22 8:43 ` Paolo Bonzini
2013-05-22 8:52 ` Michael S. Tsirkin
2013-05-22 9:22 ` Paolo Bonzini
2013-05-22 9:42 ` Michael S. Tsirkin
2013-05-22 10:40 ` Paolo Bonzini
2013-05-22 10:50 ` Michael S. Tsirkin
2013-05-22 10:51 ` Paolo Bonzini
2013-05-22 11:09 ` Michael S. Tsirkin [this message]
2013-05-22 11:12 ` Paolo Bonzini
2013-05-22 11:35 ` Michael S. Tsirkin
2013-05-25 17:32 ` Blue Swirl
2013-05-26 7:35 ` Michael S. Tsirkin
2013-05-26 9:12 ` Peter Maydell
2013-05-26 12:31 ` Michael S. Tsirkin
2013-05-26 12:48 ` Stefan Weil
2013-05-26 13:11 ` Michael S. Tsirkin
2013-05-26 13:36 ` Peter Maydell
2013-05-26 13:40 ` Michael S. Tsirkin
2013-05-26 18:20 ` Blue Swirl
2013-05-26 18:24 ` Michael S. Tsirkin
2013-05-26 19:28 ` Blue Swirl
2013-05-26 20:15 ` Michael S. Tsirkin
2013-05-26 20:29 ` Blue Swirl
2013-05-26 20:55 ` Michael S. Tsirkin
2013-05-28 10:33 ` Michael S. Tsirkin
2013-05-26 21:03 ` Anthony Liguori
2013-05-22 8:46 ` Michael S. Tsirkin
2013-05-22 9:48 ` Stefan Hajnoczi
2013-05-22 10:00 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522110922.GC5643@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).