From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf798-0006nl-Rh for qemu-devel@nongnu.org; Wed, 22 May 2013 07:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf797-00086Y-Ep for qemu-devel@nongnu.org; Wed, 22 May 2013 07:23:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf797-00086K-5Y for qemu-devel@nongnu.org; Wed, 22 May 2013 07:23:53 -0400 Date: Wed, 22 May 2013 13:23:48 +0200 From: Kevin Wolf Message-ID: <20130522112348.GE2541@dhcp-200-207.str.redhat.com> References: <1368693379-8434-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368693379-8434-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/8] block: drive-backup live backup command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini , xiawenc@linux.vnet.ibm.com Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > Note: These patches apply to my block-next tree. You can also grab the code > from git here: > git://github.com/stefanha/qemu.git block-backup-core > > This series adds a new QMP command, drive-backup, which takes a point-in-time > snapshot of a block device. The snapshot is copied out to a target block > device. A simple example is: > > drive-backup device=virtio0 format=qcow2 target=backup-20130401.qcow2 > Dietmar Maurer (1): > block: add basic backup support to block driver > > Stefan Hajnoczi (7): > block: add bdrv_add_before_write_notifier() > block: add drive-backup QMP command > qemu-iotests: add 055 drive-backup test case > blockdev: rename BlkTransactionStates to singular > blockdev: add DriveBackup transaction > blockdev: add Abort transaction > qemu-iotests: test 'drive-backup' transaction in 055 > > block.c | 18 ++- > block/Makefile.objs | 1 + > block/backup.c | 283 ++++++++++++++++++++++++++++++++++++ > blockdev.c | 264 +++++++++++++++++++++++++++------- > include/block/block_int.h | 38 ++++- > qapi-schema.json | 69 ++++++++- > qmp-commands.hx | 37 +++++ > tests/qemu-iotests/055 | 348 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/055.out | 5 + > tests/qemu-iotests/group | 1 + > 10 files changed, 1000 insertions(+), 64 deletions(-) > create mode 100644 block/backup.c > create mode 100755 tests/qemu-iotests/055 > create mode 100644 tests/qemu-iotests/055.out Commented on patches 2, 3 and 4. The others are: Reviewed-by: Kevin Wolf