From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"xiawenc@linux.vnet.ibm.com" <xiawenc@linux.vnet.ibm.com>,
"imain@redhat.com" <imain@redhat.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver
Date: Wed, 22 May 2013 15:37:16 +0200 [thread overview]
Message-ID: <20130522133716.GA28600@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <519BA4EF.1000302@redhat.com>
On Tue, May 21, 2013 at 06:46:39PM +0200, Paolo Bonzini wrote:
> Il 21/05/2013 18:26, Dietmar Maurer ha scritto:
> >> Hmm, right. But do we need the bitmap at all? We can just use
> >> > bdrv_is_allocated like bdrv_co_do_readv does.
> > Does that works with a nbd driver?
>
> Ah, right. That's the answer.
Yes, the target may not supported allocation info.
> > Or does that add another RPC call (slow down)?
>
> It doesn't work at all. Thus Stefan's patch is fine (except if you
> don't use HBitmapIter, there's no advantage in using HBitmap; you can
> use qemu/bitmap.h instead).
I chose HBitmap because bitmap.h uses the int type instead of uint64_t,
which makes it risky to use in the block layer.
Stefan
next prev parent reply other threads:[~2013-05-22 13:37 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 14:34 [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb() Stefan Hajnoczi
2013-05-15 14:42 ` Paolo Bonzini
2013-05-16 2:42 ` Wenchao Xia
2013-05-16 8:11 ` Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver Stefan Hajnoczi
2013-05-16 3:27 ` Wenchao Xia
2013-05-16 7:30 ` Stefan Hajnoczi
2013-05-20 11:30 ` Paolo Bonzini
2013-05-21 13:34 ` Stefan Hajnoczi
2013-05-21 15:11 ` Paolo Bonzini
2013-05-21 15:25 ` Dietmar Maurer
2013-05-21 15:35 ` Paolo Bonzini
2013-05-21 15:54 ` Dietmar Maurer
2013-05-21 16:03 ` Paolo Bonzini
2013-05-21 16:15 ` Dietmar Maurer
2013-05-21 16:26 ` Dietmar Maurer
2013-05-21 16:46 ` Paolo Bonzini
2013-05-22 13:37 ` Stefan Hajnoczi [this message]
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command Stefan Hajnoczi
2013-05-15 19:04 ` Eric Blake
2013-05-16 7:31 ` Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 4/8] qemu-iotests: add 055 drive-backup test case Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular Stefan Hajnoczi
2013-05-15 19:09 ` Eric Blake
2013-05-16 2:28 ` Wenchao Xia
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 6/8] blockdev: add DriveBackup transaction Stefan Hajnoczi
2013-05-15 19:13 ` Eric Blake
2013-05-16 7:36 ` Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction Stefan Hajnoczi
2013-05-15 19:01 ` Eric Blake
2013-05-16 2:26 ` Wenchao Xia
2013-05-16 7:37 ` Stefan Hajnoczi
2013-05-15 14:34 ` [Qemu-devel] [PATCH v3 8/8] qemu-iotests: test 'drive-backup' transaction in 055 Stefan Hajnoczi
2013-05-16 6:16 ` [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command Wenchao Xia
2013-05-16 7:47 ` Stefan Hajnoczi
2013-05-17 6:58 ` Wenchao Xia
2013-05-17 9:14 ` Stefan Hajnoczi
2013-05-21 3:25 ` Wenchao Xia
2013-05-21 7:34 ` Stefan Hajnoczi
2013-05-17 10:17 ` Paolo Bonzini
2013-05-20 6:24 ` Stefan Hajnoczi
2013-05-20 7:23 ` Paolo Bonzini
2013-05-21 7:31 ` Stefan Hajnoczi
2013-05-21 8:30 ` Paolo Bonzini
2013-05-21 10:34 ` Stefan Hajnoczi
2013-05-21 10:36 ` Paolo Bonzini
2013-05-21 10:58 ` Dietmar Maurer
2013-05-22 13:43 ` Stefan Hajnoczi
2013-05-22 15:10 ` Dietmar Maurer
2013-05-22 15:34 ` Dietmar Maurer
2013-05-23 8:04 ` Stefan Hajnoczi
2013-05-23 8:11 ` Dietmar Maurer
2013-05-24 8:38 ` Stefan Hajnoczi
2013-05-24 9:53 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522133716.GA28600@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).