From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Uf9eX-0002vs-43
	for qemu-devel@nongnu.org; Wed, 22 May 2013 10:04:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Uf9eV-0007nY-Ov
	for qemu-devel@nongnu.org; Wed, 22 May 2013 10:04:29 -0400
Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:44929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Uf9eV-0007md-J1
	for qemu-devel@nongnu.org; Wed, 22 May 2013 10:04:27 -0400
Received: by mail-ea0-f173.google.com with SMTP id n15so1206116ead.32
	for <qemu-devel@nongnu.org>; Wed, 22 May 2013 07:04:26 -0700 (PDT)
Date: Wed, 22 May 2013 16:04:14 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20130522140414.GL4051@smtp.vpn>
References: <1369219105-9111-1-git-send-email-edgar.iglesias@gmail.com>
	<1369219105-9111-3-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA-KDNKbwdy0i6T8DL0gO2e7UVjrJvd+bB6-u8dhy8fKUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-KDNKbwdy0i6T8DL0gO2e7UVjrJvd+bB6-u8dhy8fKUA@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on
 guest-errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On Wed, May 22, 2013 at 11:45:46AM +0100, Peter Maydell wrote:
> On 22 May 2013 11:38,  <edgar.iglesias@gmail.com> wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...)
> >          vfprintf(qemu_logfile, fmt, ap);
> >      }
> >      va_end(ap);
> > +
> > +    /*
> > +     * Break the GDB session (if connected) so that the user can inspect the
> > +     * guest state.
> > +     *
> > +     * TODO: Consider conditionalizing this on a cmdline option.
> > +     */
> 
> This is definitely way too intrusive to be unconditional -- it can
> happen really frequently (for instance Linux on OMAP3 will access
> a nonexistent register every time it takes an interrupt).

Ye, I figured this would be the case.

Maybe a qemu monitor flag controllable from the gdb client itself might be
the most useful, default off. Then one can turn the breaks on/off on
the fly while debugging.

monitor gdb_break_on_guest_errors or something like that.

Cheers,
Edgar