From: Amit Shah <amit.shah@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: peter.maydell@linaro.org, nick@bytemark.co.uk,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning
Date: Thu, 23 May 2013 16:49:18 +0530 [thread overview]
Message-ID: <20130523111918.GA10951@amit.redhat.com> (raw)
In-Reply-To: <1369175577-18130-1-git-send-email-mdroth@linux.vnet.ibm.com>
On (Tue) 21 May 2013 [17:32:57], Michael Roth wrote:
> When this VMSD was introduced it's version fields were set to
> sizeof(I6300State), making them essentially random from build to build,
> version to version.
>
> To fix this, we lock in a high version id and low minimum version id to
> support old->new migration from all prior versions of this device's
> state. This should work since the device state has not changed since
> its introduction.
>
> The potentially breaks migration from 1.5+ to 1.5, but since the
> versioning was essentially random prior to this patch, new->old
> migration was not consistently functional to begin with.
>
> Reported-by: Nicholas Thomas <nick@bytemark.co.uk>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Please fix the comment below per Laszlo's comment, and you can add:
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
next prev parent reply other threads:[~2013-05-23 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 22:32 [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning Michael Roth
2013-05-22 8:25 ` Laszlo Ersek
2013-05-23 11:19 ` Amit Shah [this message]
2013-06-12 20:11 ` mdroth
2013-06-12 20:42 ` Peter Maydell
2013-06-12 21:07 ` mdroth
2013-06-12 21:17 ` Anthony Liguori
2013-06-12 21:27 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523111918.GA10951@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=nick@bytemark.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).