From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfTuP-0002ZN-Ck for qemu-devel@nongnu.org; Thu, 23 May 2013 07:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfTuJ-00053o-Pu for qemu-devel@nongnu.org; Thu, 23 May 2013 07:42:13 -0400 Date: Thu, 23 May 2013 16:49:18 +0530 From: Amit Shah Message-ID: <20130523111918.GA10951@amit.redhat.com> References: <1369175577-18130-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369175577-18130-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: peter.maydell@linaro.org, nick@bytemark.co.uk, qemu-devel@nongnu.org, qemu-stable@nongnu.org On (Tue) 21 May 2013 [17:32:57], Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to > support old->new migration from all prior versions of this device's > state. This should work since the device state has not changed since > its introduction. > > The potentially breaks migration from 1.5+ to 1.5, but since the > versioning was essentially random prior to this patch, new->old > migration was not consistently functional to begin with. > > Reported-by: Nicholas Thomas > Suggested-by: Peter Maydell > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael Roth Please fix the comment below per Laszlo's comment, and you can add: Reviewed-by: Amit Shah Amit