From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UfXWT-00016c-LA
	for qemu-devel@nongnu.org; Thu, 23 May 2013 11:33:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UfXWO-0003uQ-Jp
	for qemu-devel@nongnu.org; Thu, 23 May 2013 11:33:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UfXWO-0003u7-CM
	for qemu-devel@nongnu.org; Thu, 23 May 2013 11:33:40 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NFXd8F025570
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 23 May 2013 11:33:39 -0400
Date: Thu, 23 May 2013 11:33:37 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130523113337.15955383@redhat.com>
In-Reply-To: <20130523145756.GC24256@redhat.com>
References: <1369300080-31377-1-git-send-email-akong@redhat.com>
	<1369300080-31377-2-git-send-email-akong@redhat.com>
	<20130523102459.GD16892@redhat.com>
	<20130523102842.61a02d2e@redhat.com>
	<20130523144325.GC24037@redhat.com> <519E2D20.9060003@redhat.com>
	<20130523145756.GC24256@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED
	event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

On Thu, 23 May 2013 17:57:56 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote:
> > On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
> > >>> Please stress this is only for the NIC. It does not apply
> > >>> to non-NIC netclients.
> > >>
> > >> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit
> > >> generic.
> > > 
> > > What do you suggest?
> > > NIC_RX_FILTER_CHANGED ?
> > 
> > Yes, that might work.  (And whatever name we bikeshed, insert it in the
> > correct sorted order in the file)
> > 
> > > 
> > >> Also, although I haven't reviewed the next patch yet, I think you
> > >> should move the event trigger to this patch.
> > > 
> > > That's hard because of the flag that's shared with the query
> > > command.
> > 
> > It's fine if this patch declares and sets the flag, but the event is
> > one-shot until the next patch adds the query to clear the flag.  And
> > again, the flag should be per-device, not global.
> 
> Maybe just merge both patches together. They are pretty small anyway.

That's what I was going to suggest if it's really hard to move the
event to this patch.