From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfUNq-0005kl-4I for qemu-devel@nongnu.org; Thu, 23 May 2013 08:12:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfUNk-0000i0-Ty for qemu-devel@nongnu.org; Thu, 23 May 2013 08:12:37 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:58759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfUNk-0000hr-ND for qemu-devel@nongnu.org; Thu, 23 May 2013 08:12:32 -0400 Received: by mail-wi0-f172.google.com with SMTP id m6so771560wiv.17 for ; Thu, 23 May 2013 05:12:32 -0700 (PDT) Date: Thu, 23 May 2013 14:12:29 +0200 From: Stefan Hajnoczi Message-ID: <20130523121229.GJ9093@stefanha-thinkpad.redhat.com> References: <20130521153333.4880.74390.stgit@hds.com> <20130521153341.4880.11812.stgit@hds.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130521153341.4880.11812.stgit@hds.com> Subject: Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, vrozenfe@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: > Add C++ keywords to avoid errors in compiling with c++ compiler. > This also renames class member of PciDeviceInfo to q_class. > > Signed-off-by: Tomoki Sekiyama > --- > hmp.c | 2 +- > hw/pci/pci.c | 2 +- > scripts/qapi.py | 9 ++++++++- > 3 files changed, 10 insertions(+), 3 deletions(-) Please also extend scripts/checkpatch.pl. Otherwise it is very likely that C++ keywords will be introduced again in the future. Most people will not build the VSS code and therefore checkpatch.pl needs to ensure that patches with C++ keywords will not be accepted. Stefan