From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfVC0-0000Oq-7M for qemu-devel@nongnu.org; Thu, 23 May 2013 09:04:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfVBu-0003LO-LX for qemu-devel@nongnu.org; Thu, 23 May 2013 09:04:28 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:47162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfVBu-0003KI-8H for qemu-devel@nongnu.org; Thu, 23 May 2013 09:04:22 -0400 Date: Thu, 23 May 2013 22:23:13 +1000 From: David Gibson Message-ID: <20130523122313.GE26259@boomeroo.fritz.box> References: <1368059472-25071-1-git-send-email-david@gibson.dropbear.id.au> <1368059472-25071-2-git-send-email-david@gibson.dropbear.id.au> <20130523111135.GC17480@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jKBxcB1XkHIR0Eqt" Content-Disposition: inline In-Reply-To: <20130523111135.GC17480@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org --jKBxcB1XkHIR0Eqt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote: > On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote: [snip] > > diff --git a/hw/pci/pci-hotplug-old.c b/hw/pci/pci-hotplug-old.c > > new file mode 100644 > > index 0000000..724a80b > > --- /dev/null > > +++ b/hw/pci/pci-hotplug-old.c >=20 > Please use git format-patch -M so renames are > properly shown. I can't see whether anything changed here. Ah, sorry. Forgot that wasn't the default. > > @@ -0,0 +1,290 @@ > > +/* > > + * QEMU PCI hotplug support >=20 > I don't particularly mind whether it's called pci-hotplug or > pci-hotplug-old, but I'm prepared to go with you on this. > However, what we really should do is fix the comment > to match reality. Good point. > I think this needs two commits: > - fix comment > - rename >=20 > to make format-patch -M detect this as a rename Hrm, I think it should detect the rename, even with a change to the comment. But I'll check to make sure, and split if necessary. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jKBxcB1XkHIR0Eqt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGeCjEACgkQaILKxv3ab8YOpgCeJFufYoS+ydaW2LEXwzQ9o/K4 +6MAnRH8JKSL3UQEPYzyex3+x0neDmCe =4tGW -----END PGP SIGNATURE----- --jKBxcB1XkHIR0Eqt--