From: Stefan Hajnoczi <stefanha@gmail.com>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, vrozenfe@redhat.com, pbonzini@redhat.com,
seiji.aguchi@hds.com, areis@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v3 11/11] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly
Date: Thu, 23 May 2013 14:30:08 +0200 [thread overview]
Message-ID: <20130523123008.GM9093@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20130521153415.4880.53934.stgit@hds.com>
On Tue, May 21, 2013 at 11:34:16AM -0400, Tomoki Sekiyama wrote:
> qemu-ga in Windows may return error message with multibyte characters
> when the guest OS language is set to other than English. To display such
> messages correctly, this encodes the message based on the locale settings.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
> QMP/qmp.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/QMP/qmp.py b/QMP/qmp.py
> index c551df1..ee21819 100644
> --- a/QMP/qmp.py
> +++ b/QMP/qmp.py
> @@ -11,6 +11,7 @@
> import json
> import errno
> import socket
> +import locale
>
> class QMPError(Exception):
> pass
> @@ -133,7 +134,8 @@ class QEMUMonitorProtocol:
> def command(self, cmd, **kwds):
> ret = self.cmd(cmd, kwds)
> if ret.has_key('error'):
> - raise Exception(ret['error']['desc'])
> + enc = locale.getpreferredencoding()
> + raise Exception(ret['error']['desc'].encode(enc))
You should not need to explicitly encode the error descriptor. The
error description should be UTF-8 on the wire and a Unicode Python
string in this script.
I think the real problem is:
1. Guest qga is writing strings in local encoding onto the wire.
or
2. qmp.py isn't UTF-8-decoding strings received over the wire.
Either or both bugs could be present. Once they are fixed you shouldn't
see encoding problems.
Stefan
next prev parent reply other threads:[~2013-05-23 12:30 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 15:33 [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS Tomoki Sekiyama
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 01/11] configure: Support configuring c++ compiler Tomoki Sekiyama
2013-05-21 16:42 ` Eric Blake
2013-05-21 21:02 ` Tomoki Sekiyama
2013-05-21 16:56 ` Peter Maydell
2013-05-21 21:01 ` Tomoki Sekiyama
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier Tomoki Sekiyama
2013-05-23 12:12 ` Stefan Hajnoczi
2013-05-23 18:34 ` Tomoki Sekiyama
2013-05-24 8:52 ` Stefan Hajnoczi
2013-05-24 14:20 ` Tomoki Sekiyama
2013-05-24 15:25 ` Markus Armbruster
2013-05-27 11:43 ` Stefan Hajnoczi
2013-05-24 13:01 ` Laszlo Ersek
2013-05-24 14:33 ` Tomoki Sekiyama
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system Tomoki Sekiyama
2013-05-21 16:48 ` Eric Blake
2013-05-21 21:02 ` Tomoki Sekiyama
2013-05-24 13:14 ` Laszlo Ersek
2013-05-24 13:38 ` Laszlo Ersek
2013-05-24 15:59 ` Eric Blake
2013-05-24 18:27 ` Laszlo Ersek
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 04/11] qemu-ga: Add an configure option to specify path to Windows VSS SDK Tomoki Sekiyama
2013-05-21 16:53 ` Eric Blake
2013-05-21 21:02 ` Tomoki Sekiyama
2013-05-24 13:48 ` Laszlo Ersek
2013-05-24 14:03 ` Laszlo Ersek
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze Tomoki Sekiyama
2013-05-23 12:22 ` Stefan Hajnoczi
2013-05-23 18:36 ` Tomoki Sekiyama
2013-05-24 8:54 ` Stefan Hajnoczi
2013-05-24 14:30 ` Tomoki Sekiyama
2013-05-28 21:01 ` Jeff Cody
2013-05-29 7:39 ` Stefan Hajnoczi
2013-05-31 2:15 ` Tomoki Sekiyama
2013-05-21 15:33 ` [Qemu-devel] [RFC PATCH v3 06/11] qemu-ga: Add Windows VSS requester to quisce applications and filesystems Tomoki Sekiyama
2013-05-21 16:56 ` Eric Blake
2013-05-21 21:02 ` Tomoki Sekiyama
2013-05-28 20:17 ` Jeff Cody
2013-05-31 5:06 ` Tomoki Sekiyama
2013-05-21 15:34 ` [Qemu-devel] [RFC PATCH v3 07/11] qemu-ga: call Windows VSS requester in fsfreeze command handler Tomoki Sekiyama
2013-05-21 15:34 ` [Qemu-devel] [RFC PATCH v3 08/11] qemu-ga: install Windows VSS provider on `qemu-ga -s install' Tomoki Sekiyama
2013-05-21 15:34 ` [Qemu-devel] [RFC PATCH v3 09/11] qemu-ga: Add VSS provider .tlb file in the repository Tomoki Sekiyama
2013-05-28 21:07 ` Jeff Cody
2013-05-21 15:34 ` [Qemu-devel] [RFC PATCH v3 10/11] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command Tomoki Sekiyama
2013-05-21 15:34 ` [Qemu-devel] [RFC PATCH v3 11/11] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly Tomoki Sekiyama
2013-05-23 12:30 ` Stefan Hajnoczi [this message]
2013-05-24 18:55 ` Tomoki Sekiyama
2013-05-27 12:06 ` Stefan Hajnoczi
2013-05-23 11:05 ` [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS Laszlo Ersek
2013-05-23 17:11 ` Tomoki Sekiyama
2013-05-23 12:15 ` Stefan Hajnoczi
2013-05-23 13:20 ` Paolo Bonzini
2013-05-23 13:28 ` Stefan Hajnoczi
2013-05-23 13:50 ` Paolo Bonzini
2013-05-24 8:59 ` Stefan Hajnoczi
2013-05-24 12:08 ` Paolo Bonzini
2013-05-24 9:20 ` Stefan Hajnoczi
2013-05-27 4:13 ` Libaiqing
2013-05-27 7:01 ` Tomoki Sekiyama
2013-05-27 10:00 ` Libaiqing
2013-05-31 1:30 ` Libaiqing
2013-05-31 2:20 ` Tomoki Sekiyama
2013-06-03 9:12 ` Libaiqing
2013-06-03 12:20 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523123008.GM9093@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=areis@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=tomoki.sekiyama@hds.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).