From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState.
Date: Thu, 23 May 2013 15:44:05 +0200 [thread overview]
Message-ID: <20130523134405.GO9093@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1369280289-20928-2-git-send-email-famz@redhat.com>
On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote:
> @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque);
> static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
> void *s, void *sp)
> {
> + BDRVCURLState *bs = s;
bs is used for BlockDriverState in block/* code. I find this confusing.
Usually the custom state is called 's'. Perhaps just rename the void*
arguments s_ and sp_.
next prev parent reply other threads:[~2013-05-23 13:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 3:37 [Qemu-devel] [PATCH v5 00/11] curl: fix curl read Fam Zheng
2013-05-23 3:37 ` [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-23 13:44 ` Stefan Hajnoczi [this message]
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 02/11] curl: change magic number to sizeof Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 03/11] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 04/11] curl: fix curl_open Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState Fam Zheng
2013-05-23 13:55 ` Stefan Hajnoczi
2013-05-24 2:59 ` Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 06/11] curl: introduce CURLDataCache Fam Zheng
2013-05-23 14:09 ` Stefan Hajnoczi
2013-05-24 3:00 ` Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache Fam Zheng
2013-05-23 14:23 ` Stefan Hajnoczi
2013-05-24 3:10 ` Fam Zheng
2013-05-24 9:44 ` Stefan Hajnoczi
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 08/11] curl: use list to store CURLState Fam Zheng
2013-05-23 14:32 ` Stefan Hajnoczi
2013-05-24 5:07 ` Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 09/11] curl: add cache quota Fam Zheng
2013-05-23 14:33 ` Stefan Hajnoczi
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 10/11] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-23 3:38 ` [Qemu-devel] [PATCH v5 11/11] block/curl.c: Refuse to open the handle for writes Fam Zheng
2013-05-23 8:16 ` [Qemu-devel] [PATCH v5 00/11] curl: fix curl read Richard W.M. Jones
2013-05-23 14:37 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523134405.GO9093@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).