From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UfVoT-0007RY-Il
	for qemu-devel@nongnu.org; Thu, 23 May 2013 09:44:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UfVoO-0001zX-Mw
	for qemu-devel@nongnu.org; Thu, 23 May 2013 09:44:13 -0400
Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:39695)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UfVoO-0001zM-H9
	for qemu-devel@nongnu.org; Thu, 23 May 2013 09:44:08 -0400
Received: by mail-wg0-f53.google.com with SMTP id m15so2228673wgh.32
	for <qemu-devel@nongnu.org>; Thu, 23 May 2013 06:44:07 -0700 (PDT)
Date: Thu, 23 May 2013 15:44:05 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130523134405.GO9093@stefanha-thinkpad.redhat.com>
References: <1369280289-20928-1-git-send-email-famz@redhat.com>
	<1369280289-20928-2-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1369280289-20928-2-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to
 BDRVCURLState.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote:
> @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque);
>  static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
>                          void *s, void *sp)
>  {
> +    BDRVCURLState *bs = s;

bs is used for BlockDriverState in block/* code.  I find this confusing.
Usually the custom state is called 's'.  Perhaps just rename the void*
arguments s_ and sp_.