From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfWxa-0003bf-Ol for qemu-devel@nongnu.org; Thu, 23 May 2013 10:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfWxT-0006Z0-HT for qemu-devel@nongnu.org; Thu, 23 May 2013 10:57:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfWxT-0006Yu-9b for qemu-devel@nongnu.org; Thu, 23 May 2013 10:57:35 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NEvYT4008518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 May 2013 10:57:34 -0400 Date: Thu, 23 May 2013 17:57:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20130523145756.GC24256@redhat.com> References: <1369300080-31377-1-git-send-email-akong@redhat.com> <1369300080-31377-2-git-send-email-akong@redhat.com> <20130523102459.GD16892@redhat.com> <20130523102842.61a02d2e@redhat.com> <20130523144325.GC24037@redhat.com> <519E2D20.9060003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519E2D20.9060003@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Amos Kong , qemu-devel@nongnu.org, stefanha@redhat.com, Luiz Capitulino On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: > On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: > >>> Please stress this is only for the NIC. It does not apply > >>> to non-NIC netclients. > >> > >> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit > >> generic. > > > > What do you suggest? > > NIC_RX_FILTER_CHANGED ? > > Yes, that might work. (And whatever name we bikeshed, insert it in the > correct sorted order in the file) > > > > >> Also, although I haven't reviewed the next patch yet, I think you > >> should move the event trigger to this patch. > > > > That's hard because of the flag that's shared with the query > > command. > > It's fine if this patch declares and sets the flag, but the event is > one-shot until the next patch adds the query to clear the flag. And > again, the flag should be per-device, not global. Maybe just merge both patches together. They are pretty small anyway. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >