From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfXUv-00071l-HW for qemu-devel@nongnu.org; Thu, 23 May 2013 11:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfXUm-00034F-Gw for qemu-devel@nongnu.org; Thu, 23 May 2013 11:32:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfXUm-00034B-8R for qemu-devel@nongnu.org; Thu, 23 May 2013 11:32:00 -0400 Date: Thu, 23 May 2013 18:32:21 +0300 From: "Michael S. Tsirkin" Message-ID: <20130523153221.GA30191@redhat.com> References: <1369319649-23900-1-git-send-email-mst@redhat.com> <20130523145643.GA24256@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130523145643.GA24256@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/10] virtio: import headers from linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Thu, May 23, 2013 at 05:56:43PM +0300, Michael S. Tsirkin wrote: > On Thu, May 23, 2013 at 03:41:07PM +0100, Peter Maydell wrote: > > On 23 May 2013 15:34, Michael S. Tsirkin wrote: > > > I'm working on adding new virtio layout to qemu. > > > The job is complicated by the fact that > > > qemu has its own copy of the virtio headers, > > > sometimes with slightly different names > > > and structure. > > > Import headers from linux instead. > > > > Do the kernel guys guarantee that their headers will > > compile on all the platforms QEMU supports? [eg windows] > > (this isn't an issue for the current uses of linux-headers > > because we only use it for KVM support, and if KVM is > > enabled you're definitely on a Linux host.) > > > > thanks > > -- PMM > > No but at the moment there's nothing there besides harmless > defines. > > But it's not like we update these things automatically. > > If/when things break, we can change update-headers to strip > problematic stuff out of there. Or so I thought but in practice there's a dependency on linux/types.h However, that's pretty easy to address. I can think of two ways: - strip linux/types.h in update_headers - add a stub linux/types.h for non linux platforms Preferences? > -- > MST