Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c

[David Gibson <dwg@au1.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]

On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote:
[snip]
> > diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs
> > index a7fb9d0..2ad32b6 100644
> > --- a/hw/pci/Makefile.objs
> > +++ b/hw/pci/Makefile.objs
> > @@ -8,4 +8,4 @@ common-obj-$(CONFIG_PCI) += pcie.o pcie_aer.o pcie_port.o
> >  common-obj-$(CONFIG_NO_PCI) += pci-stub.o
> >  common-obj-$(CONFIG_ALL) += pci-stub.o
> >  
> > -obj-$(CONFIG_PCI_HOTPLUG) += pci-hotplug.o
> > +obj-$(CONFIG_PCI_HOTPLUG_OLD) += pci-hotplug-old.o
> > diff --git a/hw/pci/pci-hotplug-old.c b/hw/pci/pci-hotplug-old.c
> > new file mode 100644
> > index 0000000..724a80b
> > --- /dev/null
> > +++ b/hw/pci/pci-hotplug-old.c
> 
> Please use git format-patch -M so renames are
> properly shown. I can't see whether anything changed here.
> 
> > @@ -0,0 +1,290 @@
> > +/*
> > + * QEMU PCI hotplug support
> 
> I don't particularly mind whether it's called pci-hotplug or
> pci-hotplug-old, but I'm prepared to go with you on this.
> However, what we really should do is fix the comment
> to match reality.

Good point.  Comment updated in my tree.

> I think this needs two commits:
> - fix comment
> - rename
> 
> to make format-patch -M detect this as a rename

I verified that even with the comment change and rename in the same
patch, git format-patch -M detects the rename.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]