From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufn2c-0007DH-H5 for qemu-devel@nongnu.org; Fri, 24 May 2013 04:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ufn2X-00087P-Er for qemu-devel@nongnu.org; Fri, 24 May 2013 04:07:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufn2X-00087G-5J for qemu-devel@nongnu.org; Fri, 24 May 2013 04:07:53 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4O87qXw027025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 May 2013 04:07:52 -0400 Date: Fri, 24 May 2013 09:07:48 +0100 From: "Richard W.M. Jones" Message-ID: <20130524080748.GI4515@redhat.com> References: <1369373827-9152-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369373827-9152-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, May 24, 2013 at 01:36:55PM +0800, Fam Zheng wrote: > Changes from v5: > 05: Rename bs to s for BDRVCURLState. > 06: Use int64_t for offsets. > Fix printf format string. > Move introducing of use_count to 07. > 07: Drop explicit cast. > Use int64_t for offsets. > Use_count moved here. > 08: Remove duplicated. > Move s->url = NULL to separate patch. > 09: Fix while(0); > 12: Added: > curl: set s->url to NULL after free. This patch is definitely not working. The guest sees loads of disk errors like this: [ 30.880265] sd 2:0:0:0: [sda] [ 30.880265] Add. Sense: I/O process terminated [ 30.880265] sd 2:0:0:0: [sda] CDB: [ 30.880265] Read(10): 28 00 00 bf b0 87 00 00 01 00 [ 32.030702] sd 2:0:0:0: [sda] [ 32.031663] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 32.031663] sd 2:0:0:0: [sda] [ 32.031663] Sense Key : Aborted Command [current] [ 32.031663] sd 2:0:0:0: [sda] [ 32.031663] Add. Sense: I/O process terminated [ 32.031663] sd 2:0:0:0: [sda] CDB: [ 32.031663] Read(10): 28 00 00 00 08 46 00 00 01 00 [ 32.031663] blk_update_request: 32 callbacks suppressed [ 32.031663] end_request: I/O error, dev sda, sector 2118 [ 32.031663] quiet_error: 46 callbacks suppressed [ 32.031663] Buffer I/O error on device sda1, logical block 2055 [ 32.031663] sd 2:0:0:0: [sda] [ 32.031663] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 32.031663] sd 2:0:0:0: [sda] [ 32.031663] Sense Key : Aborted Command [current] [ 32.031663] sd 2:0:0:0: [sda] [ 32.031663] Add. Sense: I/O process terminated [ 32.031663] sd 2:0:0:0: [sda] CDB: [ 32.031663] Read(10): 28 00 00 00 08 45 00 00 01 00 [ 32.031663] end_request: I/O error, dev sda, sector 2117 [ 32.031663] Buffer I/O error on device sda1, logical block 2054 [ 32.031663] sd 2:0:0:0: [sda] (qemu doesn't crash) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)