From: Stefan Hajnoczi <stefanha@gmail.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c
Date: Fri, 24 May 2013 13:35:22 +0200 [thread overview]
Message-ID: <20130524113522.GA23160@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1369298836-17416-3-git-send-email-xiawenc@linux.vnet.ibm.com>
On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote:
> -int bdrv_is_snapshot(BlockDriverState *bs)
> -{
> - return !!(bs->open_flags & BDRV_O_SNAPSHOT);
> -}
No need to respin, but this function has nothing to do with the other
functions. This function is about -drive snapshot=on, the others are
about internal snapshots.
It should not go into block/snapshot.c. At least it should be
documented as having nothing to do with internal snapshots.
Stefan
next prev parent reply other threads:[~2013-05-24 11:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:47 [Qemu-devel] [PATCH V2 0/5] qapi and snapshot code clean up in block layer Wenchao Xia
2013-05-23 8:47 ` [Qemu-devel] [PATCH V2 1/5] block: drop bs_snapshots global variable Wenchao Xia
2013-05-23 8:47 ` [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c Wenchao Xia
2013-05-24 11:35 ` Stefan Hajnoczi [this message]
2013-05-23 8:47 ` [Qemu-devel] [PATCH V2 3/5] block: move qmp and info dump related code to block/qapi.c Wenchao Xia
2013-05-23 8:47 ` [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf() Wenchao Xia
2013-05-23 15:05 ` Eric Blake
2013-05-24 1:41 ` Wenchao Xia
2013-05-23 17:14 ` Luiz Capitulino
2013-05-24 11:45 ` Stefan Hajnoczi
2013-05-23 8:47 ` [Qemu-devel] [PATCH V2 5/5] block: dump to specified output for bdrv_snapshot_dump() and bdrv_image_info_dump() Wenchao Xia
2013-05-23 15:31 ` Eric Blake
2013-05-24 1:48 ` Wenchao Xia
2013-05-24 2:31 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524113522.GA23160@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).