From: "Richard W.M. Jones" <rjones@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Evgeny Voevodin <e.voevodin@samsung.com>,
qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] Remove unnecessary break statements
Date: Fri, 24 May 2013 13:33:10 +0100 [thread overview]
Message-ID: <20130524123310.GA20470@redhat.com> (raw)
In-Reply-To: <1369390765-32117-1-git-send-email-sw@weilnetz.de>
On Fri, May 24, 2013 at 12:19:25PM +0200, Stefan Weil wrote:
> Fix these warnings from cppcheck:
>
> hw/display/cirrus_vga.c:2603:
> hw/sd/sd.c:348:
> hw/timer/exynos4210_mct.c:1033:
> target-arm/translate.c:9886:
> target-s390x/mem_helper.c:518:
> target-unicore32/translate.c:1936:
> style: Consecutive return, break, continue, goto or throw statements are unnecessary.
I'm not sure what cppcheck does, but I spotted an unnecessary break
statement in the watchdog code a few days ago:
http://git.qemu.org/?p=qemu.git;a=blob;f=hw/watchdog/watchdog.c;h=cb4e1f9e479f934532fcd4d07528feccba812b79;hb=HEAD#l131
(line 131)
So it's obviously not finding them all :-(
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
next prev parent reply other threads:[~2013-05-24 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 10:19 [Qemu-devel] [PATCH] Remove unnecessary break statements Stefan Weil
2013-05-24 10:21 ` Peter Maydell
2013-05-24 11:40 ` Andreas Färber
2013-05-24 12:33 ` Richard W.M. Jones [this message]
2013-05-25 5:44 ` Stefan Weil
2013-05-25 9:23 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524123310.GA20470@redhat.com \
--to=rjones@redhat.com \
--cc=agraf@suse.de \
--cc=e.voevodin@samsung.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).