qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
Date: Sun, 26 May 2013 16:40:45 +0300	[thread overview]
Message-ID: <20130526134045.GA26267@redhat.com> (raw)
In-Reply-To: <CAFEAcA_KGu=zkkVPUdAJk6+Y9MU9ucnW7_ynD6SPRSGpnPuSfg@mail.gmail.com>

On Sun, May 26, 2013 at 02:36:28PM +0100, Peter Maydell wrote:
> On 26 May 2013 13:31, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, May 26, 2013 at 10:12:21AM +0100, Peter Maydell wrote:
> >> I definitely think individual project makefiles are the wrong place
> >> to fix this. If create-as-temp-and-rename is useful functionality
> >> it needs to go in the compiler so that everybody benefits.
> >
> > This will not help users on existing systems.
> > Also it's not just compiler. We'd have to do it in linker,
> > asm, ... lots of work.
> 
> This is clearly less work than implementing it in the makefile
> of every single open source project in the world (or even every
> single open source project in Debian).

You seem to have removed the part that explained that
1. we run scripts in our makefiles so need to handle that anyway
2. we care about users on existing systems

This means that we would need the fix in our makefiles even
if compiler and linker gain this feature.

> > You are wellcome to implement this in compiler/linker/etc if you like
> > but we will still want to handle it in our makefile as well.
> 
> I specifically don't want it handled in our makefiles because
> it's the wrong place to fix the problem and it will make
> our build system more complicated.
> 
> -- PMM

  reply	other threads:[~2013-05-26 13:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 21:46 [Qemu-devel] [PATCH] makefile: detect corrupted elf files Michael S. Tsirkin
2013-05-21 22:01 ` Peter Maydell
2013-05-21 22:09   ` Michael S. Tsirkin
2013-05-22  7:44     ` Markus Armbruster
2013-05-22  8:37       ` Michael S. Tsirkin
2013-05-22  8:38         ` Peter Maydell
2013-05-22  8:43           ` Paolo Bonzini
2013-05-22  8:52             ` Michael S. Tsirkin
2013-05-22  9:22               ` Paolo Bonzini
2013-05-22  9:42                 ` Michael S. Tsirkin
2013-05-22 10:40                   ` Paolo Bonzini
2013-05-22 10:50                     ` Michael S. Tsirkin
2013-05-22 10:51                       ` Paolo Bonzini
2013-05-22 11:09                         ` Michael S. Tsirkin
2013-05-22 11:12                           ` Paolo Bonzini
2013-05-22 11:35                             ` Michael S. Tsirkin
2013-05-25 17:32                               ` Blue Swirl
2013-05-26  7:35                                 ` Michael S. Tsirkin
2013-05-26  9:12                                   ` Peter Maydell
2013-05-26 12:31                                     ` Michael S. Tsirkin
2013-05-26 12:48                                       ` Stefan Weil
2013-05-26 13:11                                         ` Michael S. Tsirkin
2013-05-26 13:36                                       ` Peter Maydell
2013-05-26 13:40                                         ` Michael S. Tsirkin [this message]
2013-05-26 18:20                                           ` Blue Swirl
2013-05-26 18:24                                             ` Michael S. Tsirkin
2013-05-26 19:28                                               ` Blue Swirl
2013-05-26 20:15                                                 ` Michael S. Tsirkin
2013-05-26 20:29                                                   ` Blue Swirl
2013-05-26 20:55                                                     ` Michael S. Tsirkin
2013-05-28 10:33                                                     ` Michael S. Tsirkin
2013-05-26 21:03                                               ` Anthony Liguori
2013-05-22  8:46           ` Michael S. Tsirkin
2013-05-22  9:48 ` Stefan Hajnoczi
2013-05-22 10:00   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130526134045.GA26267@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).