From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UgbBb-0004wq-2p
	for qemu-devel@nongnu.org; Sun, 26 May 2013 09:40:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UgbBU-0000u0-L8
	for qemu-devel@nongnu.org; Sun, 26 May 2013 09:40:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UgbBU-0000tu-Bm
	for qemu-devel@nongnu.org; Sun, 26 May 2013 09:40:28 -0400
Date: Sun, 26 May 2013 16:40:45 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130526134045.GA26267@redhat.com>
References: <20130522105034.GA5643@redhat.com> <519CA33E.9010109@redhat.com>
	<20130522110922.GC5643@redhat.com> <519CA80F.4090502@redhat.com>
	<20130522113510.GA7707@redhat.com>
	<CAAu8pHsLfE5dhEErsdYwfn9kj+z4nH6V8KPQgV94-QSUbRHv_A@mail.gmail.com>
	<20130526073540.GA32691@redhat.com>
	<CAFEAcA9PYP=P=57yxmLKgGwHTq-9HG-Ei3-L2Dh9PWOzMX-t0w@mail.gmail.com>
	<20130526123142.GA6865@redhat.com>
	<CAFEAcA_KGu=zkkVPUdAJk6+Y9MU9ucnW7_ynD6SPRSGpnPuSfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_KGu=zkkVPUdAJk6+Y9MU9ucnW7_ynD6SPRSGpnPuSfg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

On Sun, May 26, 2013 at 02:36:28PM +0100, Peter Maydell wrote:
> On 26 May 2013 13:31, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, May 26, 2013 at 10:12:21AM +0100, Peter Maydell wrote:
> >> I definitely think individual project makefiles are the wrong place
> >> to fix this. If create-as-temp-and-rename is useful functionality
> >> it needs to go in the compiler so that everybody benefits.
> >
> > This will not help users on existing systems.
> > Also it's not just compiler. We'd have to do it in linker,
> > asm, ... lots of work.
> 
> This is clearly less work than implementing it in the makefile
> of every single open source project in the world (or even every
> single open source project in Debian).

You seem to have removed the part that explained that
1. we run scripts in our makefiles so need to handle that anyway
2. we care about users on existing systems

This means that we would need the fix in our makefiles even
if compiler and linker gain this feature.

> > You are wellcome to implement this in compiler/linker/etc if you like
> > but we will still want to handle it in our makefile as well.
> 
> I specifically don't want it handled in our makefiles because
> it's the wrong place to fix the problem and it will make
> our build system more complicated.
> 
> -- PMM