From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44851)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1Ugctb-0003tc-ER
	for qemu-devel@nongnu.org; Sun, 26 May 2013 11:30:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UgctZ-0007sx-HN
	for qemu-devel@nongnu.org; Sun, 26 May 2013 11:30:07 -0400
Received: from mail-ie0-x230.google.com ([2607:f8b0:4001:c03::230]:48447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1UgctZ-0007sP-Ct
	for qemu-devel@nongnu.org; Sun, 26 May 2013 11:30:05 -0400
Received: by mail-ie0-f176.google.com with SMTP id at1so16366883iec.21
	for <qemu-devel@nongnu.org>; Sun, 26 May 2013 08:30:04 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Sun, 26 May 2013 10:26:48 -0500
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130526152648.GA4599@vm>
References: <CAAu8pHscBsGCz1Hb7m3q1bJ86PpwLhsq5AP+HCqiaNLGcSqMAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAu8pHscBsGCz1Hb7m3q1bJ86PpwLhsq5AP+HCqiaNLGcSqMAQ@mail.gmail.com>
Subject: Re: [Qemu-devel] make check breakage on 32 bit hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Sun, May 26, 2013 at 12:00:57PM +0000, Blue Swirl wrote:
> I get this on i386 chroot for make check:
> 
> GTESTER tests/test-qmp-output-visitor
> **
> ERROR:/src/qemu/tests/test-qmp-output-visitor.c:595:check_native_list:
> assertion failed: (tmp)
> GTester: last random seed: R02S559792e7c8d0762d9a2ee153fba8896c
> **

Tests case looks correct, problem seems to be that we cast list node to
GenericList, which expects the 'value' field to be a pointer type. With
native lists types these are in some cases non-pointer types, like
intList, where 'value' is an int64_t. On 32-bit archs this cast leads to
use uses incorrect offset when trying to traverse the list.

Don't see a way to fix this outside of making the code generators do
a bit of massaging for these cases rather than a cast. Looking at it
now, but might not be able to send a patch till later.