From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugf5t-0001Vd-MZ for qemu-devel@nongnu.org; Sun, 26 May 2013 13:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugf5n-0005Hb-5Q for qemu-devel@nongnu.org; Sun, 26 May 2013 13:50:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugf5m-0005HX-Mu for qemu-devel@nongnu.org; Sun, 26 May 2013 13:50:50 -0400 Date: Sun, 26 May 2013 20:51:10 +0300 From: "Michael S. Tsirkin" Message-ID: <20130526175110.GA3115@redhat.com> References: <1369581694-1655-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , qemu-devel@nongnu.org On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote: > On 26 May 2013 16:22, Michael S. Tsirkin wrote: > > virtio linux headers are actually pretty portable: > > all we need is implement linux/types.h in a portable > > way, and we can import them and use on any platform. > > > > These patches do exactly that, as a pre-requisite > > to adding support for new virtio layout. > > > > Note: if someone adds non-portable code in files we import from linux-headers, > > we'll have to revert to copying code manually. This didn't happen yet so > > hopefully it won't. > > This series breaks compilation on MacOSX: > > CC net/eth.o > In file included from net/eth.c:18: > In file included from /Users/pm215/src/qemu/include/net/eth.h:29: > /Users/pm215/src/qemu/linux-headers/linux/if_ether.h:24:10: fatal > error: 'linux/types.h' file not found > #include > ^ > 1 error generated. > make: *** [net/eth.o] Error 1 > > thanks > -- PMM Could be a stale file in your tree ... Did configure get re-run? Could you post the config-host.mak file please?