From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgtID-0006eF-7E for qemu-devel@nongnu.org; Mon, 27 May 2013 05:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgtI9-00068E-EP for qemu-devel@nongnu.org; Mon, 27 May 2013 05:00:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgtI9-000688-80 for qemu-devel@nongnu.org; Mon, 27 May 2013 05:00:33 -0400 Date: Mon, 27 May 2013 11:00:22 +0200 From: Stefan Hajnoczi Message-ID: <20130527090022.GF21969@stefanha-thinkpad.redhat.com> References: <1369406295-20411-1-git-send-email-stefanha@redhat.com> <1369406295-20411-3-git-send-email-stefanha@redhat.com> <519F84B1.4080705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519F84B1.4080705@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] rtl8139: flush queued packets when RxBufPtr is written List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , qemu-devel@nongnu.org On Fri, May 24, 2013 at 05:18:09PM +0200, Paolo Bonzini wrote: > Il 24/05/2013 16:38, Stefan Hajnoczi ha scritto: > > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > > index 9369507..7993f9f 100644 > > --- a/hw/net/rtl8139.c > > +++ b/hw/net/rtl8139.c > > @@ -2575,6 +2575,9 @@ static void rtl8139_RxBufPtr_write(RTL8139State *s, uint32_t val) > > /* this value is off by 16 */ > > s->RxBufPtr = MOD2(val + 0x10, s->RxBufferSize); > > > > + /* more buffer space may be available so try to receive */ > > + qemu_flush_queued_packets(qemu_get_queue(s->nic)); > > + > > DPRINTF(" CAPR write: rx buffer length %d head 0x%04x read 0x%04x\n", > > s->RxBufferSize, s->RxBufAddr, s->RxBufPtr); > > } > > > > Do you have time to update the branch with a "Cc: qemu-stable@nongnu.org"? It has been merged. Will try to CC qemu-stable in the future. Stefan