From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgzYX-0001l3-Ez for qemu-devel@nongnu.org; Mon, 27 May 2013 11:42:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgzYP-0001j5-NV for qemu-devel@nongnu.org; Mon, 27 May 2013 11:41:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgzYP-0001io-GI for qemu-devel@nongnu.org; Mon, 27 May 2013 11:41:45 -0400 Date: Mon, 27 May 2013 17:41:39 +0200 From: Kevin Wolf Message-ID: <20130527154139.GH2373@dhcp-200-207.str.redhat.com> References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: > These patches are the common part of my hmp/qmp block query series and Pavel's > qmp snapshot command converion series. It mainly does following things: > 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to > block/qapi.c. > 2 better info dumping function to get rid of buffer, avoid string truncation. Posted comments on patch 1 and 4. Patches 2 and 3 are: Reviewed-by: Kevin Wolf